From: Ulf Hansson <ulf.hansson@linaro.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: vub300: Use scnprintf() for avoiding potential buffer overflow
Date: Thu, 12 Mar 2020 14:08:26 +0100 [thread overview]
Message-ID: <CAPDyKFpQCFSX5iRzxHgJ3xXoYzUo7GZs50a6v7YHvkRUTYFE2Q@mail.gmail.com> (raw)
In-Reply-To: <20200311080439.13928-1-tiwai@suse.de>
On Wed, 11 Mar 2020 at 09:04, Takashi Iwai <tiwai@suse.de> wrote:
>
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit. Fix it by replacing with scnprintf().
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/vub300.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index 6ced1b7f642f..4008871bc2ec 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -1363,7 +1363,7 @@ static void download_offload_pseudocode(struct vub300_mmc_host *vub300)
> int retval;
> for (n = 0; n < sdio_funcs; n++) {
> struct sdio_func *sf = card->sdio_func[n];
> - l += snprintf(vub300->vub_name + l,
> + l += scnprintf(vub300->vub_name + l,
> sizeof(vub300->vub_name) - l, "_%04X%04X",
> sf->vendor, sf->device);
> }
> --
> 2.16.4
>
prev parent reply other threads:[~2020-03-12 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 8:04 [PATCH] mmc: vub300: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-12 13:08 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpQCFSX5iRzxHgJ3xXoYzUo7GZs50a6v7YHvkRUTYFE2Q@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).