From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C491C1975A for ; Thu, 12 Mar 2020 13:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05515206FA for ; Thu, 12 Mar 2020 13:09:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="piJo3Qvo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727309AbgCLNI7 (ORCPT ); Thu, 12 Mar 2020 09:08:59 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:44018 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726632AbgCLNI7 (ORCPT ); Thu, 12 Mar 2020 09:08:59 -0400 Received: by mail-vs1-f65.google.com with SMTP id 7so3582856vsr.10 for ; Thu, 12 Mar 2020 06:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c/71/1S9FFPBZLngXcn7eOGZxEYwsgQn+LiJXaTEkt8=; b=piJo3Qvo8x1s8VTBvAp8jS5t4o5VQEuBs+lWQCHYrxpJbtweH35oefXEg9GnzRQtdz 61TRYLXGKrksVOp7wxdDFIZl5QZ824OocSJHbPk7P8hZ70jpr88EaUGavwPNoL4Dn36K Nl5oXBejzLR1jLeDJKzYb6ixDcAWzPP7oWG8OeFjKk4/PM28R2Me2D0Tsq7x8rhewXrt r9U/8MqANn4Ec6qJ2Rhiv85PM01uXdt4/JzUZZopZGKv0JxfViBO1WHel4O7GIJWC1qc CC+Rw5K2v3jnnd/eFLnzoQo/ZNl/T0nWcHZQA9pE0ttsgYASG3J1iRFvKPj7l5rZ/lPs Rsiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c/71/1S9FFPBZLngXcn7eOGZxEYwsgQn+LiJXaTEkt8=; b=WoKnvcv3zJL8grg0nGyS1P3jsLAHS2jlluGX/XPVgF3LOZntFu4z98sTRJBUDkj3Om PSfSnCVJ2lxbrcPKdA434ltF5Lb5yx0qn4gfMmzGcop87nl/+AKS8bnOtwJs71TJKES9 E2T/+BY1E38bwQGX85Dd/wJLf8CGyXUk1bpnA+OFDkV83L4Wpm11NEoL3sbKXfdJADVN vJ4vljVsxdRn6m9oECXuUbRwyQw9da9L2+7cRnkaGViQ+/8YtNQ0SueuJJdaVOYMVu+a 5q47MIUr7OXMEgMdEi0orYW6TeNM+3aLGKyfYoqARXJH6X/86Xqi0fOQRDeA8/tr4K5g UG5w== X-Gm-Message-State: ANhLgQ1P0NHusyq661ukjzuOpohcpp9DgQqe19Hg6KGdJGZgeb6e+Omf Qq/BgDPFWNUtaUUD9P/2iGdfRcPofqCmq0OD+6uCIw== X-Google-Smtp-Source: ADFU+vvkBY6+7KljoIBo06yuh++7mQGBlfwWaxlmBrxgvs2H6ahSYqDiyk/zugbPV+nCMOkSfEf3tQK6yQglm6UvXwc= X-Received: by 2002:a05:6102:2051:: with SMTP id q17mr5487529vsr.165.1584018537836; Thu, 12 Mar 2020 06:08:57 -0700 (PDT) MIME-Version: 1.0 References: <20200307160556.16226-1-jbx6244@gmail.com> In-Reply-To: <20200307160556.16226-1-jbx6244@gmail.com> From: Ulf Hansson Date: Thu, 12 Mar 2020 14:08:21 +0100 Message-ID: Subject: Re: [PATCH v1] dt-bindings: mmc: synopsys-dw-mshc: fix clock-freq-min-max in example To: Johan Jonker Cc: Heiko Stuebner , Rob Herring , "linux-mmc@vger.kernel.org" , DTML , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Sat, 7 Mar 2020 at 17:06, Johan Jonker wrote: > > A test with the command below does not detect all errors > in combination with 'additionalProperties: false' and > allOf: > - $ref: "synopsys-dw-mshc-common.yaml#" > allOf: > - $ref: "mmc-controller.yaml#" > > 'additionalProperties' applies to all properties that are not > accounted-for by 'properties' or 'patternProperties' in > the immediate schema. > > First when we combine synopsys-dw-mshc.yaml, > synopsys-dw-mshc-common.yaml and mmc-controller.yaml it gives > this error: > > Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.example.dt.yaml: > mmc@12200000: 'clock-freq-min-max' does not match any of the regexes: > '^.*@[0-9]+$', '^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)| > uhs-(sdr(12|25|50|104)|ddr50))$', 'pinctrl-[0-9]+' > > 'clock-freq-min-max' is deprecated, so replace it by 'max-frequency'. > > make ARCH=arm dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > > Signed-off-by: Johan Jonker Applied for next, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > index 05f9f36dc..dd2c1b147 100644 > --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml > @@ -62,7 +62,7 @@ examples: > cap-mmc-highspeed; > cap-sd-highspeed; > card-detect-delay = <200>; > - clock-freq-min-max = <400000 200000000>; > + max-frequency = <200000000>; > clock-frequency = <400000000>; > data-addr = <0x200>; > fifo-depth = <0x80>; > -- > 2.11.0 >