Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Y.b. Lu" <yangbo.lu@nxp.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Sachin Miglani <sachin.miglani@nxp.com>
Subject: Re: [PATCH] mmc: sdhci: fix up CMD12 sending
Date: Thu, 16 Jan 2020 16:36:35 +0100
Message-ID: <CAPDyKFq7VnfYAs=RcjUpskAfSC_fatksQ1_sJ6wEOinbPDKmkQ@mail.gmail.com> (raw)
In-Reply-To: <AM7PR04MB68856B9D41A5867AB39D37F2F83E0@AM7PR04MB6885.eurprd04.prod.outlook.com>

On Wed, 8 Jan 2020 at 10:37, Y.b. Lu <yangbo.lu@nxp.com> wrote:
>
> Hi Uffe and Adrian,
>
> Back again on this topic. Actually we are trying to make the error recovery work after data error of CMD18 in linux-4.14.
> With this patch, when CMD18 data error got, manual CMD12 would be sent. And then went into mmc_blk_cmd_recovery(). (Should be mmc_blk_mq_rw_recovery() in latest linux-5.5-rc2.)
> In mmc_blk_cmd_recovery(), re-tuning would fail before sending CMD13 on our specific board.
> This may be some issue related to specific eMMC card we are investigating.
>
> The above is just background introduction, and you may not care about that:)
> I'd like to have some queries on CMD12 usage in MMC driver.
> 1. It seems CMD12 is always not using ABORT type for sending in sdhci.c. The SDHCI_CMD_ABORTCMD hasn't been used. Is this issue?

I defer that question to Adrian.

> 2. In block.c, CMD12 uses R1 response for data reading and R1B response for writing. Is it ok to use R1 response for SD? The SD spec mentions only R1B response for CMD12.

I think the specs isn't that clear on this. In this case, the R1B, is
an R1 with an *optional* busy signaling on DAT0, unless it has been
changed lately.

Additionally, as far as can tell, there have been no reports about
problems with the current approach for "reads". Are you saying there
is?

[...]

Kind regards
Uffe

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191114111814.35199-1-yangbo.lu@nxp.com>
2019-11-29  9:17 ` Adrian Hunter
2019-12-10  9:51 ` Ulf Hansson
2020-01-08  9:37   ` Y.b. Lu
2020-01-16 15:36     ` Ulf Hansson [this message]
2020-01-17 14:15       ` Adrian Hunter

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFq7VnfYAs=RcjUpskAfSC_fatksQ1_sJ6wEOinbPDKmkQ@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=sachin.miglani@nxp.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git