linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: weiyj_lk@163.com
Cc: Chris Ball <chris@printf.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Ondrej Zary <linux@rainbow-software.org>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH -next] mmc: toshsd: use module_pci_driver to simplify the code
Date: Fri, 19 Dec 2014 11:48:59 +0100	[thread overview]
Message-ID: <CAPDyKFqOACKx=Kkku+J2YbLTcL0pt+Q4YUFm8T3EdzeqU09KVA@mail.gmail.com> (raw)
In-Reply-To: <1418087285-14334-1-git-send-email-weiyj_lk@163.com>

On 9 December 2014 at 02:08,  <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use the module_pci_driver() macro to make the code simpler
> by eliminating module_init and module_exit calls.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks! Queued for 3.20.

Kind regards
Uffe

> ---
>  drivers/mmc/host/toshsd.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/mmc/host/toshsd.c b/drivers/mmc/host/toshsd.c
> index 4666262..e5d8dec 100644
> --- a/drivers/mmc/host/toshsd.c
> +++ b/drivers/mmc/host/toshsd.c
> @@ -699,18 +699,7 @@ static struct pci_driver toshsd_driver = {
>         .driver.pm = &toshsd_pm_ops,
>  };
>
> -static int __init toshsd_drv_init(void)
> -{
> -       return pci_register_driver(&toshsd_driver);
> -}
> -
> -static void __exit toshsd_drv_exit(void)
> -{
> -       pci_unregister_driver(&toshsd_driver);
> -}
> -
> -module_init(toshsd_drv_init);
> -module_exit(toshsd_drv_exit);
> +module_pci_driver(toshsd_driver);
>
>  MODULE_AUTHOR("Ondrej Zary, Richard Betts");
>  MODULE_DESCRIPTION("Toshiba PCI Secure Digital Host Controller Interface driver");
>

      reply	other threads:[~2014-12-19 10:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09  1:08 [PATCH -next] mmc: toshsd: use module_pci_driver to simplify the code weiyj_lk
2014-12-19 10:48 ` Ulf Hansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFqOACKx=Kkku+J2YbLTcL0pt+Q4YUFm8T3EdzeqU09KVA@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=chris@printf.net \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=weiyj_lk@163.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).