From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552A4C433E1 for ; Fri, 10 Jul 2020 07:58:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34761207BC for ; Fri, 10 Jul 2020 07:58:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gizcXlck" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725802AbgGJH6s (ORCPT ); Fri, 10 Jul 2020 03:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgGJH6r (ORCPT ); Fri, 10 Jul 2020 03:58:47 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B236AC08C5DC for ; Fri, 10 Jul 2020 00:58:47 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id u133so2519612vsc.0 for ; Fri, 10 Jul 2020 00:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Diu8FPSk0YQQ/9KsIVHjWkR640rhqQzr3+RMJoJoM1g=; b=gizcXlckz2M67ld6mSAeGM1bMlmeOkCCvNRWT7Vxi1AEXDbep0iGhPQoPlPyNipDCo rDanyYCfqFnKRZVMrCKD+Q/KOeIV0SPfpteq76Qp607FT9oVWpG0vnZ5n3ev5Ih979p0 Q8kTOQ8m1JPR1WjyTUWGZaPzoRByowv73z17YAf5lItx0pNj7dNwxJuwHtMWXc81uSdV 2JExDCRtZHvk35n6+Is1Gd/whndlmF3a86z+GMgwSMgfm6CAxnOYvENB8qU8bHiP9MAF 5bU1xVX02rEFo1o4ntyxe6ndnQRMHh7dBGHhqEtqp70zk5VJ4/tAKZ8CdyRKACRpuUWZ zKtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Diu8FPSk0YQQ/9KsIVHjWkR640rhqQzr3+RMJoJoM1g=; b=bPX4g+0HP1q4qYrBxVoeza6i28hNzogAZhnrNeZ5+dZ0m4AFbNt6ZPUrnY4iCn8dFQ DipKCNOKFPlImboI5MrbkCt+H40vQ5HmWYQW6V4rauCIzmAAsp6pQfte+KBDe/f7sJKn 7ZQy9zQvj7SAJ2SXUGH7tX/+fHZOYdeA9lWxFT+xylxgP2+GsAarSeqDu+ON1WiMlfig 7AB2y7I5Ceq4kNSk9u4w5iPY3Kp2AphOze5DPZX55iquizR/T+1vXSKNdJ9O10UkK/ZF szKNQIKsyd8rV1MNcX2yeY5QHdH/OF47Absj+6OwamuQniCTCfP75VqmChl5hXfvAzub stqw== X-Gm-Message-State: AOAM532plXksCQrFSGMizb8nIC1NudVBSR1OVqkCqCpNaf+WgTB4s4aS dfxY0RjlC8TUm+pzISMdjPezgLLL2+eny02HSN/+0A== X-Google-Smtp-Source: ABdhPJxPYSpMEhKAbJpUN77i+R+I1788d/Ems0i5GSKwTLANWpFKgAUr6sQNT4PO8IlvGncOYNGftRvmLJTjgk/y7ts= X-Received: by 2002:a05:6102:22f3:: with SMTP id b19mr4543062vsh.191.1594367926935; Fri, 10 Jul 2020 00:58:46 -0700 (PDT) MIME-Version: 1.0 References: <1594300408-17658-1-git-send-email-vbadigan@codeaurora.org> In-Reply-To: <1594300408-17658-1-git-send-email-vbadigan@codeaurora.org> From: Ulf Hansson Date: Fri, 10 Jul 2020 09:58:10 +0200 Message-ID: Subject: Re: [PATCH V1] mmc: sdhci: Fix potential null pointer access while accessing vqmmc To: Veerabhadrarao Badiganti Cc: Adrian Hunter , Dan Carpenter , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-arm-msm , Vijay Viswanath Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, 9 Jul 2020 at 15:13, Veerabhadrarao Badiganti wrote: > > Don't access vqmmc regulator handler, if it's already invalidated. > > Fixes: f870b6d480d3 (mmc: sdhci: Allow platform controlled voltage switching) > Reported-by: Dan Carpenter > Signed-off-by: Veerabhadrarao Badiganti Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index e6275c2202b0..d3b62fc5c661 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -4383,11 +4383,6 @@ int sdhci_setup_host(struct sdhci_host *host) > if (!IS_ERR(mmc->supply.vqmmc)) { > if (enable_vqmmc) { > ret = regulator_enable(mmc->supply.vqmmc); > - if (ret) { > - pr_warn("%s: Failed to enable vqmmc regulator: %d\n", > - mmc_hostname(mmc), ret); > - mmc->supply.vqmmc = ERR_PTR(-EINVAL); > - } > host->sdhci_core_to_disable_vqmmc = !ret; > } > > @@ -4402,6 +4397,13 @@ int sdhci_setup_host(struct sdhci_host *host) > if (!regulator_is_supported_voltage(mmc->supply.vqmmc, 2700000, > 3600000)) > host->flags &= ~SDHCI_SIGNALING_330; > + > + if (ret) { > + pr_warn("%s: Failed to enable vqmmc regulator: %d\n", > + mmc_hostname(mmc), ret); > + mmc->supply.vqmmc = ERR_PTR(-EINVAL); > + } > + > } > > if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V) { > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project >