From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A5FC43332 for ; Mon, 11 Jan 2021 18:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87BCA229CA for ; Mon, 11 Jan 2021 18:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390205AbhAKSIK (ORCPT ); Mon, 11 Jan 2021 13:08:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390221AbhAKSIJ (ORCPT ); Mon, 11 Jan 2021 13:08:09 -0500 Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9811FC0617BB for ; Mon, 11 Jan 2021 10:07:01 -0800 (PST) Received: by mail-ua1-x92d.google.com with SMTP id f16so114707uav.12 for ; Mon, 11 Jan 2021 10:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kjroq5IVcsaocRlWVqumBmAjNs8Q1T2UaLZmChWgxjU=; b=XEEsKYXMfqgNLBsBkUHKknxUjINn9OYd+Vbtf7fXC+xDMBW+NzkCwoOG5tYyW0TbLk 2MB6siADi+yjsiMKcNz1rRo55EPwSQolwPp1Zg2iZx1W/ZYi+gpj55YvUDAnFc5A8bC3 pWi3H4E5yjoCzI/7mp/+y2lZRdSfshXZuwuNipS6Jb25c/xXqJcplYXo/0lJFGy6YAsw YOlxp5r6cDjojE1przzzBB6fxaNCL0/YIlTtwFGAT06GMgAJigNHbg8XcZhxLttHBgdR ln16xnYPacs9YMm5DYAqeBqHXLywSLWQ6zzL8UUDYNLjK9Gmufqy4k0GwV9iHrhSP1m4 84xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kjroq5IVcsaocRlWVqumBmAjNs8Q1T2UaLZmChWgxjU=; b=hCZ1CAfTh6Z5idULGVNl+l0Ozfs1+7tGFtKTiAR/RQlu4E9LB+itBMIgiRdp2r/12K 55d9ff2CutsaiHgcNuxnq0JDacmkBxQwlY2xmZe8aT9J/Vxt1Vk8KGRyKbl+Dy6fr32q DxlsMog4e/IPOL0DjEbQgSUbuhq/OoANcmSoTSeWLCR4XE3yhjGud1v3hIP/owGSwh9V ApyO4+/pAUbyTPnbO0b+XWJmHjjGR6M/0u97kLHZrF5TTtulb4rR57QNLsM359lyvwnD U6QrcFy5uWsnHUgp0nRf3ZLJHt8Sted0/1pN2JttrWzTgv4TUdj0IYYbOQ7BxKt0frlF JXxA== X-Gm-Message-State: AOAM533KKEdegnW9OUgIe1UPnoOvEfUZV9p7lGO/6ymaz3h+Oes+vuRA 3Tql7Kesnwcg6esziRTYj8MyKp+Xh823okZQkKYi6Z56hK3Png== X-Google-Smtp-Source: ABdhPJxMPRMEkGTAbXkhnrrN+swnMYAQSC+WKmQmUp8nsi7df3jLRu3fgfIQ6FiYJhzQrb9jsDMgCm19+v6Gjlha7XU= X-Received: by 2002:ab0:78d:: with SMTP id c13mr653601uaf.129.1610388420862; Mon, 11 Jan 2021 10:07:00 -0800 (PST) MIME-Version: 1.0 References: <20201211141656.24915-1-mw@semihalf.com> In-Reply-To: <20201211141656.24915-1-mw@semihalf.com> From: Ulf Hansson Date: Mon, 11 Jan 2021 19:06:24 +0100 Message-ID: Subject: Re: [PATCH] mmc: sdhci-xenon: fix 1.8v regulator stabilization To: Marcin Wojtas Cc: Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , Ziji Hu , Adrian Hunter , jaz@semihalf.com, tn@semihalf.com, Kostya Porotchkin , Alex Leibovich , "# 4.0+" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Fri, 11 Dec 2020 at 15:17, Marcin Wojtas wrote: > > From: Alex Leibovich > > Automatic Clock Gating is a feature used for the power > consumption optimisation. It turned out that > during early init phase it may prevent the stable voltage > switch to 1.8V - due to that on some platfroms an endless > printout in dmesg can be observed: > "mmc1: 1.8V regulator output did not became stable" > Fix the problem by disabling the ACG at very beginning > of the sdhci_init and let that be enabled later. > > Fixes: 3a3748dba881 ("mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality") > Signed-off-by: Alex Leibovich > Signed-off-by: Marcin Wojtas > Cc: stable@vger.kernel.org Applied for fixes (by fixing the typos), thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-xenon.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c > index c67611fdaa8a..4b05f6fdefb4 100644 > --- a/drivers/mmc/host/sdhci-xenon.c > +++ b/drivers/mmc/host/sdhci-xenon.c > @@ -168,7 +168,12 @@ static void xenon_reset_exit(struct sdhci_host *host, > /* Disable tuning request and auto-retuning again */ > xenon_retune_setup(host); > > - xenon_set_acg(host, true); > + /* > + * The ACG should be turned off at the early init time, in order > + * to solve a possile issues with the 1.8V regulator stabilization. > + * The feature is enabled in later stage. > + */ > + xenon_set_acg(host, false); > > xenon_set_sdclk_off_idle(host, sdhc_id, false); > > -- > 2.29.0 >