From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [RFC PATCH 00/13] mmc: host: Add facility to support re-tuning Date: Fri, 19 Dec 2014 15:37:47 +0100 Message-ID: References: <1417801271-15575-1-git-send-email-adrian.hunter@intel.com> <5494312C.9080004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-qg0-f53.google.com ([209.85.192.53]:45015 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbaLSOhr (ORCPT ); Fri, 19 Dec 2014 09:37:47 -0500 Received: by mail-qg0-f53.google.com with SMTP id l89so688361qgf.40 for ; Fri, 19 Dec 2014 06:37:47 -0800 (PST) In-Reply-To: <5494312C.9080004@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Adrian Hunter Cc: Chris Ball , linux-mmc , Aaron Lu , Philip Rakity , Girish K S , Al Cooper , Arend van Spriel On 19 December 2014 at 15:07, Adrian Hunter wrote: > On 05/12/14 19:40, Adrian Hunter wrote: >> Hi >> >> Here are some patches to move re-tuning support out of >> sdhci and into the core, and add support for HS400 >> re-tuning. >> >> Currently sdhci does re-tuning transparently by >> calling sdhci_execute_tuning() from its ->request() >> function. >> >> The problem with HS400 re-tuning is that it must be >> done in HS200 mode. That means using switch commands >> and making ios changes. That means it potentially >> conflicts with other command sequences. The new >> re-tuning support accomodates that, however it is >> not strictly necessary because HS400 re-tuning >> should only be needed after runtime suspend when >> there would not be a conflict. >> >> Nevertheless, this approach has more structure >> and potentially more flexibility. >> >> >> Adrian Hunter (13): >> mmc: core: Simplify by adding mmc_execute_tuning() >> mmc: host: Add facility to support re-tuning >> mmc: core: Disable re-tuning when card is no longer initialized >> mmc: core: Move mmc_card_removed() into mmc_start_request() >> mmc: core: Add support for re-tuning before each request >> mmc: core: Check re-tuning before retrying >> mmc: core: Hold re-tuning during switch commands >> mmc: core: Hold re-tuning during erase commands >> mmc: core: Hold re-tuning while bkops ongoing >> mmc: mmc: Comment that callers need to hold re-tuning if the card is put to sleep >> mmc: core: Add support for HS400 re-tuning >> mmc: sdhci: Always init buf_ready_int >> mmc: sdhci: Change to new way of doing re-tuning >> >> drivers/mmc/core/core.c | 93 +++++++++++++++++++++++++++++++----- >> drivers/mmc/core/core.h | 5 ++ >> drivers/mmc/core/host.c | 63 +++++++++++++++++++++++++ >> drivers/mmc/core/mmc.c | 58 ++++++++++++++++++----- >> drivers/mmc/core/mmc_ops.c | 31 ++++++++---- >> drivers/mmc/core/sd.c | 13 ++--- >> drivers/mmc/core/sdio.c | 14 ++---- >> drivers/mmc/host/sdhci.c | 115 ++++++--------------------------------------- >> include/linux/mmc/host.h | 58 +++++++++++++++++++++++ >> include/linux/mmc/sdhci.h | 3 -- >> 10 files changed, 296 insertions(+), 157 deletions(-) > > Ulf, do you have any comments? > I am going through them as soon as I can. It's been a busy time lately. Kind regards Uffe