* [PATCH] mmc: mmci: Add small comment about reset thread
@ 2021-09-21 14:33 Linus Walleij
2021-09-23 18:50 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2021-09-21 14:33 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson
Cc: Linus Walleij, Russell King, Yann Gautier, Ludovic Barre
Put a small comment before assigning IRQ_WAKE_THREAD
telling us what is going on.
Cc: Russell King <linux@armlinux.org.uk>
Cc: Yann Gautier <yann.gautier@foss.st.com>
Cc: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mmc/host/mmci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 3765e2f4ad98..c9cacd4d5b22 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -1394,6 +1394,10 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd,
} else if (host->variant->busy_timeout && busy_resp &&
status & MCI_DATATIMEOUT) {
cmd->error = -ETIMEDOUT;
+ /*
+ * This will wake up mmci_irq_thread() which will issue
+ * a hardware reset of the MMCI block.
+ */
host->irq_action = IRQ_WAKE_THREAD;
} else {
cmd->resp[0] = readl(base + MMCIRESPONSE0);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: mmci: Add small comment about reset thread
2021-09-21 14:33 [PATCH] mmc: mmci: Add small comment about reset thread Linus Walleij
@ 2021-09-23 18:50 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-09-23 18:50 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-mmc, Russell King, Yann Gautier, Ludovic Barre
On Tue, 21 Sept 2021 at 16:36, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Put a small comment before assigning IRQ_WAKE_THREAD
> telling us what is going on.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Yann Gautier <yann.gautier@foss.st.com>
> Cc: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mmci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index 3765e2f4ad98..c9cacd4d5b22 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -1394,6 +1394,10 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd,
> } else if (host->variant->busy_timeout && busy_resp &&
> status & MCI_DATATIMEOUT) {
> cmd->error = -ETIMEDOUT;
> + /*
> + * This will wake up mmci_irq_thread() which will issue
> + * a hardware reset of the MMCI block.
> + */
> host->irq_action = IRQ_WAKE_THREAD;
> } else {
> cmd->resp[0] = readl(base + MMCIRESPONSE0);
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-23 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 14:33 [PATCH] mmc: mmci: Add small comment about reset thread Linus Walleij
2021-09-23 18:50 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).