From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4002FC3404D for ; Wed, 19 Feb 2020 10:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1995B24656 for ; Wed, 19 Feb 2020 10:29:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zzcA9hwk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726707AbgBSK3g (ORCPT ); Wed, 19 Feb 2020 05:29:36 -0500 Received: from mail-vs1-f66.google.com ([209.85.217.66]:37422 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgBSK3g (ORCPT ); Wed, 19 Feb 2020 05:29:36 -0500 Received: by mail-vs1-f66.google.com with SMTP id x18so15091196vsq.4 for ; Wed, 19 Feb 2020 02:29:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=N/FWsOslLeWJ8wc9PPiLEWzxti0Lz4tyLMKB84GK8Qg=; b=zzcA9hwk8oBqEzK/Sk5smaykWWWhkqLgdN2ggNaL0cspzNwa1q+GoinNOOoh2h9V51 Lv7ZUcQx+nj4ydcgo+MumePOIXyd+adldZYvoZGHUzMACLER4enSZC94mRb28MJr6c1A J0zDWaHD7YQ525Kl6Y1gatEtQ406L9F6WgmgJkakqPk8Q+C9ZZgLDbcn0PVAxkoeaFBp u1Zh99N7KbfqvYQDnfJFNmIip0HZ15FT2UcLc3U/w813BeSgu1q8swKVqPbRLuHM9XJ3 Uxz065dq2yY9KSl+injyEt5q+2tCcO4d067fxfYm7S/GKS+XZflxxlWeTWxnoNcErJqI wpGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=N/FWsOslLeWJ8wc9PPiLEWzxti0Lz4tyLMKB84GK8Qg=; b=AHG16uwmyQXlR9uPYNb6ixLBIE07psKNmsn6wgt50wV70sr+FHGhXL+YTji3DPM9pJ nqa+u3wJNZXdgJ0UwwJqVB3PQ73OdHFway0GgSbEHiu0cC+GWFZ50wOJmridHUSOm88m D4oQOfkq895eY8K9WeHcwQo9ozsIYeTdx++9bJOn9Gsz1AEqW8Oo4Nwo21l6C2g0tFGg 5XBB+4clElW+c603q/hLoJ3zwT6YXGi0nwQ8GB963wNVMQtxwLCVZ7AxMBpFPinCFEQn 1RmuhNgtTXe9TZi+76vrNrh1kJxKP2Dk7Mk9ll+SASl00If3xsm4voISy+M+Dtf7V2OY 0GlQ== X-Gm-Message-State: APjAAAWZTNyGyOLzndnbMrT/zonjM/eT0+Pcd6Sgizx6aBbFpplK3jm/ fJ4w8nSAK4LesPf93+7U1yYq4dg902bWWn5FItkXtw== X-Google-Smtp-Source: APXvYqwdd1WVvropN/Ah9GWZ4j1iP+qWglk6pATFnqpFpANspIETm+lPq1ohJHYuPnh9a1IcHgjcTAcwzRPQ36OkB7Q= X-Received: by 2002:a67:5e45:: with SMTP id s66mr13897757vsb.200.1582108175469; Wed, 19 Feb 2020 02:29:35 -0800 (PST) MIME-Version: 1.0 References: <20200128090636.13689-1-ludovic.barre@st.com> <20200128090636.13689-10-ludovic.barre@st.com> <853f4b14-a188-f329-34e5-8e88fcafa775@st.com> In-Reply-To: <853f4b14-a188-f329-34e5-8e88fcafa775@st.com> From: Ulf Hansson Date: Wed, 19 Feb 2020 11:28:59 +0100 Message-ID: Subject: Re: [PATCH V2 9/9] mmc: mmci: add sdmmc variant revision 2.0 To: Ludovic BARRE Cc: Rob Herring , Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Tue, 11 Feb 2020 at 15:44, Ludovic BARRE wrote: > > hi Ulf > > Le 1/28/20 =C3=A0 10:06 AM, Ludovic Barre a =C3=A9crit : > > This patch adds a sdmmc variant revision 2.0. > > This revision is backward compatible with 1.1, and adds dma > > link list support. > > > > Signed-off-by: Ludovic Barre > > --- > > drivers/mmc/host/mmci.c | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > > index 24e630183ed4..a774c329c212 100644 > > --- a/drivers/mmc/host/mmci.c > > +++ b/drivers/mmc/host/mmci.c > > @@ -275,6 +275,31 @@ static struct variant_data variant_stm32_sdmmc =3D= { > > .init =3D sdmmc_variant_init, > > }; > > > > +static struct variant_data variant_stm32_sdmmcv2 =3D { > > + .fifosize =3D 16 * 4, > > + .fifohalfsize =3D 8 * 4, > > + .f_max =3D 208000000, > > + .stm32_clkdiv =3D true, > > + .cmdreg_cpsm_enable =3D MCI_CPSM_STM32_ENABLE, > > + .cmdreg_lrsp_crc =3D MCI_CPSM_STM32_LRSP_CRC, > > + .cmdreg_srsp_crc =3D MCI_CPSM_STM32_SRSP_CRC, > > + .cmdreg_srsp =3D MCI_CPSM_STM32_SRSP, > > + .cmdreg_stop =3D MCI_CPSM_STM32_CMDSTOP, > > + .data_cmd_enable =3D MCI_CPSM_STM32_CMDTRANS, > > + .irq_pio_mask =3D MCI_IRQ_PIO_STM32_MASK, > > + .datactrl_first =3D true, > > + .datacnt_useless =3D true, > > + .datalength_bits =3D 25, > > + .datactrl_blocksz =3D 14, > > + .datactrl_any_blocksz =3D true, > > + .stm32_idmabsize_mask =3D GENMASK(16, 5), > > + .dma_lli =3D true, > > + .busy_timeout =3D true, > > I forget "busy_detect =3D true," property > I add this in next patch set No need for a re-send, I amended this when I applied it. > > > + .busy_detect_flag =3D MCI_STM32_BUSYD0, > > + .busy_detect_mask =3D MCI_STM32_BUSYD0ENDMASK, > > + .init =3D sdmmc_variant_init, > > +}; > > + > > static struct variant_data variant_qcom =3D { > > .fifosize =3D 16 * 4, > > .fifohalfsize =3D 8 * 4, > > @@ -2343,6 +2368,11 @@ static const struct amba_id mmci_ids[] =3D { > > .mask =3D 0xf0ffffff, > > .data =3D &variant_stm32_sdmmc, > > }, > > + { > > + .id =3D 0x00253180, > > + .mask =3D 0xf0ffffff, > > + .data =3D &variant_stm32_sdmmcv2, > > + }, > > /* Qualcomm variants */ > > { > > .id =3D 0x00051180, > > Kind regards Uffe