From: Ulf Hansson <ulf.hansson@linaro.org>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Yinbo Zhu <yinbo.zhu@nxp.com>
Subject: Re: [PATCH] mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround
Date: Thu, 19 Dec 2019 08:17:11 +0100 [thread overview]
Message-ID: <CAPDyKFrO1x_a-UpeRHYqczJYjgXGMC9Qdmtc+sQu6nexerjJ4A@mail.gmail.com> (raw)
In-Reply-To: <20191219032335.26528-1-yangbo.lu@nxp.com>
On Thu, 19 Dec 2019 at 04:24, Yangbo Lu <yangbo.lu@nxp.com> wrote:
>
> The erratum A-009204 workaround patch was reverted because of
> incorrect implementation.
>
> 8b6dc6b mmc: sdhci-of-esdhc: Revert "mmc: sdhci-of-esdhc: add
> erratum A-009204 support"
>
> This patch is to re-implement the workaround (add a 5 ms delay
> before setting SYSCTL[RSTD] to make sure all the DMA transfers
> are finished).
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
That was quick! :-)
Applied for fixes and by adding a fixes/stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 4abb781..cd3b676 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -80,6 +80,7 @@ struct sdhci_esdhc {
> bool quirk_tuning_erratum_type1;
> bool quirk_tuning_erratum_type2;
> bool quirk_ignore_data_inhibit;
> + bool quirk_delay_before_data_reset;
> bool in_sw_tuning;
> unsigned int peripheral_clock;
> const struct esdhc_clk_fixup *clk_fixup;
> @@ -759,6 +760,11 @@ static void esdhc_reset(struct sdhci_host *host, u8 mask)
> struct sdhci_esdhc *esdhc = sdhci_pltfm_priv(pltfm_host);
> u32 val;
>
> + if (esdhc->quirk_delay_before_data_reset &&
> + (mask & SDHCI_RESET_DATA) &&
> + (host->flags & SDHCI_REQ_USE_DMA))
> + mdelay(5);
> +
> sdhci_reset(host, mask);
>
> sdhci_writel(host, host->ier, SDHCI_INT_ENABLE);
> @@ -1218,6 +1224,10 @@ static void esdhc_init(struct platform_device *pdev, struct sdhci_host *host)
> if (match)
> esdhc->clk_fixup = match->data;
> np = pdev->dev.of_node;
> +
> + if (of_device_is_compatible(np, "fsl,p2020-esdhc"))
> + esdhc->quirk_delay_before_data_reset = true;
> +
> clk = of_clk_get(np, 0);
> if (!IS_ERR(clk)) {
> /*
> --
> 2.7.4
>
prev parent reply other threads:[~2019-12-19 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 3:23 [PATCH] mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround Yangbo Lu
2019-12-19 7:17 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrO1x_a-UpeRHYqczJYjgXGMC9Qdmtc+sQu6nexerjJ4A@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yangbo.lu@nxp.com \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).