From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH/RFC] mmc: core: Issue power_off_notify for eMMC Suspend-to-RAM
Date: Mon, 8 Jun 2020 10:38:56 +0000 [thread overview]
Message-ID: <TY2PR01MB3692ECD6F9945379A91CB345D8850@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAPDyKFq5yueXp4NW2fj3tvPRv0S_VDM1khAw51VeEHxG79qp+Q@mail.gmail.com>
Hi Ulf,
> From: Ulf Hansson, Sent: Monday, June 8, 2020 4:57 PM
>
> On Tue, 19 May 2020 at 13:33, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> >
> > The commit 432356793415 ("mmc: core: Enable power_off_notify for
> > eMMC shutdown sequence") enabled the power off notification
> > even if MMC_CAP2_POWEROFF_NOTIFY (MMC_CAP2_FULL_PWR_CYCLE now) is
> > not set. However, the mmc core lacks to issue the power off
> > notificaiton when Suspend-to-{RAM,Disk} happens on the system.
>
> This isn't an entirely correct description, I think.
>
> If the host supports MMC_CAP2_FULL_PWR_CYCLE (both vmmc and vqmmc can
> be powered on/off), we use power-off-notification during system
> suspend, in case the eMMC card also supports it. Otherwise we send the
> sleep command.
Yes.
> This behaviour was decided on purpose and it's mainly because without
> MMC_CAP2_FULL_PWR_CYCLE, we assume that vqmmc remains always-on. In
> this case, it simply seemed better to use the sleep command, rather
> than the power-off-notification, as we aren't really going to do a
> full power off anyway.
I understood it. However, on my environment (r8a77951-salvator-xs),
while the board is entering Suspend-to-RAM, the vqmmc and vcc are turned off.
Should I add a new flag for such environment?
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2020-06-08 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 11:33 [PATCH/RFC] mmc: core: Issue power_off_notify for eMMC Suspend-to-RAM Yoshihiro Shimoda
2020-06-04 12:17 ` Yoshihiro Shimoda
2020-06-08 8:14 ` Ulf Hansson
2020-06-08 10:39 ` Yoshihiro Shimoda
2020-06-08 11:45 ` Ulf Hansson
2020-06-08 12:36 ` Geert Uytterhoeven
2020-06-08 14:50 ` Ulf Hansson
2020-06-09 10:29 ` Yoshihiro Shimoda
2020-06-08 7:57 ` Ulf Hansson
2020-06-08 10:38 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY2PR01MB3692ECD6F9945379A91CB345D8850@TY2PR01MB3692.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).