linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ben Chuang <benchuanggli@gmail.com>, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	greg.tu@genesyslogic.com.tw, ben.chuang@genesyslogic.com.tw
Subject: Re: [RFC PATCH v2 3/6] mmc: host: Add UHS-II support in host layer
Date: Tue, 17 Mar 2020 10:17:05 +0200	[thread overview]
Message-ID: <add27a04-e018-d050-4d42-4fb5c532df8c@intel.com> (raw)
In-Reply-To: <9f861920380df9d7a6d52c905fc47643eb25f33f.1578560282.git.benchuanggli@gmail.com>

On 9/01/20 11:14 am, Ben Chuang wrote:
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> 
> Add UHS-II support in host layer

Split host layer changes from sdhci changes.

> 
> Reported-by: kbuild test robot <lkp@intel.com>

Drop "Reported-by: kbuild test robot <lkp@intel.com>"

> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> ---
>  drivers/mmc/host/Makefile                  |   1 +
>  drivers/mmc/host/{sdhci.c => sdhci-core.c} | 276 ++++++--
>  drivers/mmc/host/sdhci-milbeaut.c          |   4 +-
>  drivers/mmc/host/sdhci-of-arasan.c         |   4 +-
>  drivers/mmc/host/sdhci-of-at91.c           |   4 +-
>  drivers/mmc/host/sdhci-omap.c              |   2 +-
>  drivers/mmc/host/sdhci-pci-core.c          |   4 +-
>  drivers/mmc/host/sdhci-pxav3.c             |   4 +-
>  drivers/mmc/host/sdhci-uhs2.c              | 751 +++++++++++++++++++++
>  drivers/mmc/host/sdhci-uhs2.h              |  34 +
>  drivers/mmc/host/sdhci-xenon.c             |   4 +-
>  drivers/mmc/host/sdhci.h                   | 284 +++++++-
>  drivers/mmc/host/sdhci_am654.c             |   4 +-
>  include/linux/mmc/uhs2.h                   | 270 ++++++++
>  14 files changed, 1583 insertions(+), 63 deletions(-)
>  rename drivers/mmc/host/{sdhci.c => sdhci-core.c} (94%)
>  create mode 100644 drivers/mmc/host/sdhci-uhs2.c
>  create mode 100644 drivers/mmc/host/sdhci-uhs2.h
>  create mode 100644 include/linux/mmc/uhs2.h

Please make sdhci-uhs2 a module and do not rename sdhci.c.

References in sdhci.c to sdhci-uhs2.c will need to be enclosed by
#if IS_REACHABLE(CONFIG_SDHCI_UHS2)

Move all UHS-II definitions into sdhci-uhs2.h.  Things that are for V4 but
not necessarily UHS-II can be in sdhci.h

Make the set_power parameter change into a separate patch

Fix all spelling mistakes

Make comment style correct.

Review all checkpatch warnings and checks (i.e. --strict option)

If possible provide a link to a tree that contains the patches.

Re-base on Ulf's next branch

The patch set could use an overview of how UHS-II is different from regular SD.

In other patches there are a bunch of memory allocations on the I/O path.
That is a problem.  Memory needed should be allocated in advance.

  reply	other threads:[~2020-03-17  8:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09  9:13 [RFC PATCH v2 0/6] Add support UHS-II for GL9755 Ben Chuang
2020-01-09  9:14 ` [RFC PATCH v2 1/6] mmc: Add UHS-II support in public headers Ben Chuang
2020-01-09  9:14 ` [RFC PATCH v2 2/6] mmc: core: Add UHS-II support in core layer Ben Chuang
2020-01-09  9:14 ` [RFC PATCH v2 3/6] mmc: host: Add UHS-II support in host layer Ben Chuang
2020-03-17  8:17   ` Adrian Hunter [this message]
2020-03-18  6:53     ` Ben Chuang
2020-01-09  9:14 ` [RFC PATCH v2 4/6] mmc: uhs2: Introduce a uhs2_post_attach_sd function Ben Chuang
2020-01-09  9:15 ` [RFC PATCH v2 5/6] mmc: sdhci-uhs2: Introduce a uhs2_pre_detect_init function Ben Chuang
2020-01-09  9:15 ` [RFC PATCH v2 6/6] mmc: sdhci-pci-gli: Fix power/reset/ZC/timeout for GL9755 UHS-II mode Ben Chuang
2020-01-21  9:36 ` [RFC PATCH v2 0/6] Add support UHS-II for GL9755 Ben Chuang
2020-01-21 12:01   ` Ulf Hansson
2020-01-22 13:36     ` Ben Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=add27a04-e018-d050-4d42-4fb5c532df8c@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=ben.chuang@genesyslogic.com.tw \
    --cc=benchuanggli@gmail.com \
    --cc=greg.tu@genesyslogic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).