From: Adrian Hunter <adrian.hunter@intel.com>
To: Yangtao Li <frank.li@vivo.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/58] mmc: sdhci-pic32: Convert to platform remove callback returning void
Date: Fri, 14 Jul 2023 12:49:48 +0300 [thread overview]
Message-ID: <af01d060-dbaa-aa54-8203-3da5fcbc0a79@intel.com> (raw)
In-Reply-To: <20230713080807.69999-9-frank.li@vivo.com>
On 13/07/23 11:07, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
For the following patches:
[PATCH 09_58] mmc: sdhci-pic32: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 10_58] mmc: sdhci: milbeaut: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 12_58] mmc: sdhci-of-at91: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 15_58] mmc: sdhci-pxav3: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 19_58] mmc: xenon: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 20_58] mmc: sdhci-s3c: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 27_58] mmc: sdhci-of-arasan: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 28_58] mmc: sdhci-of-dwcmshc: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 33_58] mmc: sdhci-omap: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 34_58] mmc: sdhci-of-aspeed: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 36_58] mmc: sdhci-sprd: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 37_58] mmc: sdhci-tegra: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 38_58] mmc: sdhci-acpi: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 39_58] mmc: sdhci-esdhc-imx: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 40_58] mmc: sdhci-msm: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 47_58] mmc: sdhci-st: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 49_58] mmc: sdhci-esdhc-mcf: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1107
[PATCH 51_58] mmc: sdhci-spear: Convert to platform remove callback returning void - Yangtao Li <frank.li@vivo.com> - 2023-07-13 1108
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
next prev parent reply other threads:[~2023-07-14 9:50 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 8:07 [PATCH 01/58] mmc: sunxi: Convert to platform remove callback returning void Yangtao Li
2023-07-13 8:07 ` [PATCH 02/58] mmc: bcm2835: " Yangtao Li
2023-07-14 10:10 ` Florian Fainelli
2023-07-13 8:07 ` [PATCH 03/58] mmc: jz4740: " Yangtao Li
2023-07-13 8:20 ` Paul Cercueil
2023-07-13 8:07 ` [PATCH 04/58] mmc: litex_mmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 05/58] mmc: mtk-sd: " Yangtao Li
2023-07-13 8:07 ` [PATCH 06/58] mmc: cb710: " Yangtao Li
2023-07-14 14:15 ` Michał Mirosław
2023-07-13 8:07 ` [PATCH 07/58] mmc: davinci_mmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 08/58] mmc: dw_mmc: hi3798cv200: " Yangtao Li
2023-07-13 8:07 ` [PATCH 09/58] mmc: sdhci-pic32: " Yangtao Li
2023-07-14 9:49 ` Adrian Hunter [this message]
2023-07-13 8:07 ` [PATCH 10/58] mmc: sdhci: milbeaut: " Yangtao Li
2023-07-13 8:07 ` [PATCH 11/58] mmc: omap_hsmmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 12/58] mmc: sdhci-of-at91: " Yangtao Li
2023-07-13 8:07 ` [PATCH 13/58] mmc: omap: " Yangtao Li
2023-07-13 8:07 ` [PATCH 14/58] mmc: dw_mmc: exynos: " Yangtao Li
2023-07-13 8:11 ` Krzysztof Kozlowski
2023-07-13 9:02 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 15/58] mmc: sdhci-pxav3: " Yangtao Li
2023-07-13 8:07 ` [PATCH 16/58] mmc: rtsx_pci: " Yangtao Li
2023-07-13 9:06 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 17/58] mmc: sh_mmcif: " Yangtao Li
2023-07-13 8:07 ` [PATCH 18/58] mmc: meson-gx: " Yangtao Li
2023-07-13 8:07 ` [PATCH 19/58] mmc: xenon: " Yangtao Li
2023-07-13 8:07 ` [PATCH 20/58] mmc: sdhci-s3c: " Yangtao Li
2023-07-13 8:07 ` [PATCH 21/58] mmc: meson-mx-sdhc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 22/58] mmc: rtsx_usb_sdmmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 23/58] mmc: mxs-mmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 24/58] mmc: sdhci_am654: " Yangtao Li
2023-07-13 9:08 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 25/58] mmc: uniphier-sd: " Yangtao Li
2023-07-13 9:09 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 26/58] mmc: f-sdh30: " Yangtao Li
2023-07-13 9:12 ` Uwe Kleine-König
2023-07-14 7:51 ` Adrian Hunter
2023-07-13 8:07 ` [PATCH 27/58] mmc: sdhci-of-arasan: " Yangtao Li
2023-07-13 8:07 ` [PATCH 28/58] mmc: sdhci-of-dwcmshc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 29/58] mmc: au1xmmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 30/58] mmc: cavium-octeon: " Yangtao Li
2023-07-13 8:07 ` [PATCH 31/58] mmc: pxamci: " Yangtao Li
2023-07-13 8:07 ` [PATCH 32/58] mmc: moxart: " Yangtao Li
2023-07-13 8:07 ` [PATCH 33/58] mmc: sdhci-omap: " Yangtao Li
2023-07-13 8:07 ` [PATCH 34/58] mmc: sdhci-of-aspeed: " Yangtao Li
2023-07-13 9:13 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 35/58] mmc: meson-mx-sdio: " Yangtao Li
2023-07-13 8:07 ` [PATCH 36/58] mmc: sdhci-sprd: " Yangtao Li
2023-07-13 8:07 ` [PATCH 37/58] mmc: sdhci-tegra: " Yangtao Li
2023-07-13 8:07 ` [PATCH 38/58] mmc: sdhci-acpi: " Yangtao Li
2023-07-13 8:07 ` [PATCH 39/58] mmc: sdhci-esdhc-imx: " Yangtao Li
2023-07-13 8:07 ` [PATCH 40/58] mmc: sdhci-msm: " Yangtao Li
2023-07-13 8:44 ` Konrad Dybcio
2023-07-13 8:07 ` [PATCH 41/58] mmc: alcor: " Yangtao Li
2023-07-13 8:07 ` [PATCH 42/58] mmc: dw_mmc: rockchip: " Yangtao Li
2023-07-13 8:07 ` [PATCH 43/58] mmc: owl: " Yangtao Li
2023-07-13 8:07 ` [PATCH 44/58] mmc: wbsd: " Yangtao Li
2023-07-13 8:07 ` [PATCH 45/58] mmc: usdhi60rol0: " Yangtao Li
2023-07-13 11:44 ` Jesper Nilsson
2023-07-13 8:07 ` [PATCH 46/58] mmc: atmel-mci: " Yangtao Li
2023-07-13 8:07 ` [PATCH 47/58] mmc: sdhci-st: " Yangtao Li
2023-07-13 8:07 ` [PATCH 48/58] mmc: wmt-sdmmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 49/58] mmc: sdhci-esdhc-mcf: " Yangtao Li
2023-07-17 11:18 ` Angelo Dureghello
2023-07-13 8:07 ` [PATCH 50/58] mmc: sunplus-mmc: " Yangtao Li
2023-07-13 8:08 ` [PATCH 51/58] mmc: sdhci-spear: " Yangtao Li
2023-07-13 8:24 ` Viresh Kumar
2023-07-13 8:08 ` [PATCH 52/58] mmc: mxcmmc: " Yangtao Li
2023-07-13 8:08 ` [PATCH 53/58] mmc: mvsdio: " Yangtao Li
2023-07-13 8:08 ` [PATCH 54/58] mmc: pwrseq_simple: " Yangtao Li
2023-07-13 8:08 ` [PATCH 55/58] mmc: pwrseq: sd8787: " Yangtao Li
2023-07-13 8:08 ` [PATCH 56/58] mmc: pwrseq: " Yangtao Li
2023-07-13 8:08 ` [PATCH 57/58] mmc: renesas_sdhi: " Yangtao Li
2023-07-13 10:18 ` Geert Uytterhoeven
2023-07-13 8:08 ` [PATCH 58/58] mmc: " Yangtao Li
2023-07-14 7:49 ` Adrian Hunter
2023-07-25 8:13 ` Yangtao Li
2023-07-25 11:22 ` Adrian Hunter
2023-07-14 10:12 ` Florian Fainelli
2023-07-13 15:13 ` [PATCH 01/58] mmc: sunxi: " Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af01d060-dbaa-aa54-8203-3da5fcbc0a79@intel.com \
--to=adrian.hunter@intel.com \
--cc=frank.li@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).