Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: rrangel@google.com, nehal-bakulchandra.shah@amd.com,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-acpi: For amd device set driver type as MMC_SET_DRIVER_TYPE_A
Date: Wed, 1 Jul 2020 13:43:40 +0300
Message-ID: <b51faa2a-f465-581b-05bc-81677c8c1071@intel.com> (raw)
In-Reply-To: <20200623133347.4598-1-akshu.agrawal@amd.com>

On 23/06/20 4:33 pm, Akshu Agrawal wrote:
> HS400/HS200/eMMC HS doesn't have Preset Value register.
> Hence, sdhci_set_ios function overrides the value set by fmw to
> SDHCI_CTRL_DRV_TYPE_B.
> This patch sets drv_type to MMC_SET_DRIVER_TYPE_A
> so that host_control2 register gets updated with the required
> strength value.
> 
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-acpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index d8b76cb8698a..48ecbd0b180d 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -542,6 +542,7 @@ static int amd_select_drive_strength(struct mmc_card *card,
>  				     unsigned int max_dtr, int host_drv,
>  				     int card_drv, int *drv_type)
>  {
> +	*drv_type = MMC_SET_DRIVER_TYPE_A;
>  	return MMC_SET_DRIVER_TYPE_A;
>  }
>  
> 


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 13:33 Akshu Agrawal
2020-07-01 10:43 ` Adrian Hunter [this message]
2020-07-06 14:49 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b51faa2a-f465-581b-05bc-81677c8c1071@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=akshu.agrawal@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nehal-bakulchandra.shah@amd.com \
    --cc=rrangel@google.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git