* [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message
@ 2020-01-16 14:43 YueHaibing
2020-01-20 8:42 ` Adrian Hunter
2020-01-20 11:25 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-01-16 14:43 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, orito.takao
Cc: linux-mmc, linux-kernel, YueHaibing
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mmc/host/sdhci-milbeaut.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
index e6245b7..92f30a1 100644
--- a/drivers/mmc/host/sdhci-milbeaut.c
+++ b/drivers/mmc/host/sdhci-milbeaut.c
@@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev)
struct f_sdhost_priv *priv;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "%s: no irq specified\n", __func__);
+ if (irq < 0)
return irq;
- }
host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
if (IS_ERR(host))
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message
2020-01-16 14:43 [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message YueHaibing
@ 2020-01-20 8:42 ` Adrian Hunter
2020-01-20 11:25 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2020-01-20 8:42 UTC (permalink / raw)
To: YueHaibing, ulf.hansson, orito.takao; +Cc: linux-mmc, linux-kernel
On 16/01/20 4:43 pm, YueHaibing wrote:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-milbeaut.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
> index e6245b7..92f30a1 100644
> --- a/drivers/mmc/host/sdhci-milbeaut.c
> +++ b/drivers/mmc/host/sdhci-milbeaut.c
> @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev)
> struct f_sdhost_priv *priv;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "%s: no irq specified\n", __func__);
> + if (irq < 0)
> return irq;
> - }
>
> host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
> if (IS_ERR(host))
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message
2020-01-16 14:43 [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message YueHaibing
2020-01-20 8:42 ` Adrian Hunter
@ 2020-01-20 11:25 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-01-20 11:25 UTC (permalink / raw)
To: YueHaibing
Cc: Adrian Hunter, Takao Orito, linux-mmc, Linux Kernel Mailing List
On Thu, 16 Jan 2020 at 15:43, YueHaibing <yuehaibing@huawei.com> wrote:
>
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-milbeaut.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
> index e6245b7..92f30a1 100644
> --- a/drivers/mmc/host/sdhci-milbeaut.c
> +++ b/drivers/mmc/host/sdhci-milbeaut.c
> @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev)
> struct f_sdhost_priv *priv;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "%s: no irq specified\n", __func__);
> + if (irq < 0)
> return irq;
> - }
>
> host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
> if (IS_ERR(host))
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 14:43 [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message YueHaibing
2020-01-20 8:42 ` Adrian Hunter
2020-01-20 11:25 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).