From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B40C2D0DB for ; Sat, 25 Jan 2020 13:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B94DB206F0 for ; Sat, 25 Jan 2020 13:26:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="XdqX0XNG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbgAYN0Y (ORCPT ); Sat, 25 Jan 2020 08:26:24 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.81]:17606 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgAYN0Y (ORCPT ); Sat, 25 Jan 2020 08:26:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1579958779; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=uhia0nydQkXs9FvK21W+fvG1Vt7fdYlI0+V/jmOdos4=; b=XdqX0XNGsHQmnSoTANcmeQwQeQZMrkmSqwRq1MhPI6M8StnXHp27DxON9hGB3DM6Ft ETgBlBML8Sj49UYL5DAYx6A6tOpdSzoJuZfcVLhpoAa4DFMrMSTV6r2P55P7iGpF0h8t gnYUn7puRtlCp9ohpVcoZ4bxu2gyAR26OpeRMVMrYeuvJjYvEcz5fGNaUnnFbwl7sm4w lrixkhPb77WYr1ADY2TlEzBK5qbndc82xuG9SMIFrzp04eHFUMVGhqA55n3Wg2+UpwPL 7WguAtviR5tCuLjuds7imCxexxq9O1KNx1SuZ022AVBxilRS9h2CRlQ3y9Sc/Y9Bo+Ms arJg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPgGJhWpbcFPlOUsXhg104N+2wx4Lw==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:e075:aea3:5e36:287f] by smtp.strato.de (RZmta 46.1.7 AUTH) with ESMTPSA id k0b198w0PDQ1B1C (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sat, 25 Jan 2020 14:26:01 +0100 (CET) Subject: Re: [FSL P5020 P5040 PPC] Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates To: Michael Ellerman , Ulf Hansson Cc: Darren Stevens , mad skateman , "linux-mmc@vger.kernel.org" , Julian Margetson , "contact@a-eon.com" , "R.T.Dickinson" , linuxppc-dev , Rob Herring , Christoph Hellwig References: <20200108093903.57620-1-hdegoede@redhat.com> <20200108093903.57620-2-hdegoede@redhat.com> <61bc9265-ece0-eeb6-d4a1-4631138ecf29@intel.com> <8d67882d-04a8-0607-be4e-c1430b7fda21@redhat.com> <84a32714-ba08-74a0-0c76-3c36db44dd68@intel.com> <93446e09-5f12-800a-62fa-bf3ecea7273d@redhat.com> <399ac7d5-2518-799a-595e-f6b6878cf4ab@intel.com> <8736c5hyhr.fsf@mpe.ellerman.id.au> From: Christian Zigotzky Message-ID: Date: Sat, 25 Jan 2020 14:26:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <8736c5hyhr.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 24 January 2020 at 12:42 pm, Michael Ellerman wrote: > Ulf Hansson writes: >> On Thu, 16 Jan 2020 at 12:18, Christian Zigotzky wrote: >>> Hi All, >>> >>> We still need the attached patch for our onboard SD card interface >>> [1,2]. Could you please add this patch to the tree? >> No, because according to previous discussion that isn't the correct >> solution and more importantly it will break other archs (if I recall >> correctly). >> >> Looks like someone from the ppc community needs to pick up the ball. > That's a pretty small community these days :) :/ > > Christian can you test this please? I think I got the polarity of all > the tests right, but it's Friday night so maybe I'm wrong :) > > cheers Michael, Thanks a lot for the new patch! I compiled the RC7 of kernel 5.5 with your patch again yesterday and the kernel works without any problems with our onboard SD cards. [1] Cheers, Christian [1] http://forum.hyperion-entertainment.com/viewtopic.php?f=58&t=4384&p=49697#p49693 > > >From 975ba6e8b52d6f5358e93c1f5a47adc4a0b5fb70 Mon Sep 17 00:00:00 2001 > From: Michael Ellerman > Date: Fri, 24 Jan 2020 22:26:59 +1100 > Subject: [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc > > There's an OF helper called of_dma_is_coherent(), which checks if a > device has a "dma-coherent" property to see if the device is coherent > for DMA. > > But on some platforms devices are coherent by default, and on some > platforms it's not possible to update existing device trees to add the > "dma-coherent" property. > > So add a Kconfig symbol to allow arch code to tell > of_dma_is_coherent() that devices are coherent by default, regardless > of the presence of the property. > > Select that symbol on powerpc when NOT_COHERENT_CACHE is not set, ie. > when the system has a coherent cache. > > Fixes: 92ea637edea3 ("of: introduce of_dma_is_coherent() helper") > Cc: stable@vger.kernel.org # v3.16+ > Signed-off-by: Michael Ellerman > --- > arch/powerpc/Kconfig | 1 + > drivers/of/Kconfig | 4 ++++ > drivers/of/address.c | 6 +++++- > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 62752c3bfabf..460678ab2375 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -235,6 +235,7 @@ config PPC > select NEED_DMA_MAP_STATE if PPC64 || NOT_COHERENT_CACHE > select NEED_SG_DMA_LENGTH > select OF > + select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE > select OF_EARLY_FLATTREE > select OLD_SIGACTION if PPC32 > select OLD_SIGSUSPEND > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > index 37c2ccbefecd..d91618641be6 100644 > --- a/drivers/of/Kconfig > +++ b/drivers/of/Kconfig > @@ -103,4 +103,8 @@ config OF_OVERLAY > config OF_NUMA > bool > > +config OF_DMA_DEFAULT_COHERENT > + # arches should select this if DMA is coherent by default for OF devices > + bool > + > endif # OF > diff --git a/drivers/of/address.c b/drivers/of/address.c > index 99c1b8058559..e8a39c3ec4d4 100644 > --- a/drivers/of/address.c > +++ b/drivers/of/address.c > @@ -995,12 +995,16 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz > * @np: device node > * > * It returns true if "dma-coherent" property was found > - * for this device in DT. > + * for this device in the DT, or if DMA is coherent by > + * default for OF devices on the current platform. > */ > bool of_dma_is_coherent(struct device_node *np) > { > struct device_node *node = of_node_get(np); > > + if (IS_ENABLED(CONFIG_OF_DMA_DEFAULT_COHERENT)) > + return true; > + > while (node) { > if (of_property_read_bool(node, "dma-coherent")) { > of_node_put(node);