From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: linux-modules@vger.kernel.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>, Jessica Yu <jeyu@redhat.com>
Subject: [PATCH] shared: make scratchbuf_str static
Date: Wed, 9 Nov 2016 08:52:26 +0200 [thread overview]
Message-ID: <1478674346-29996-1-git-send-email-yauheni.kaliuta@redhat.com> (raw)
It fixes linking problem
tools/depmod.o: In function `output_symbols_bin':
depmod.c:(.text.output_symbols_bin+0x135): undefined reference to `scratchbuf_str'
for -O0 build, where gcc doesn't actually inline it.
Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---
shared/scratchbuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/shared/scratchbuf.h b/shared/scratchbuf.h
index c12e4902528f..27ea9d9f6008 100644
--- a/shared/scratchbuf.h
+++ b/shared/scratchbuf.h
@@ -19,7 +19,7 @@ int scratchbuf_alloc(struct scratchbuf *buf, size_t sz);
void scratchbuf_release(struct scratchbuf *buf);
/* Return a C string */
-inline char *scratchbuf_str(struct scratchbuf *buf)
+static inline char *scratchbuf_str(struct scratchbuf *buf)
{
return buf->bytes;
}
--
2.7.4
next reply other threads:[~2016-11-09 6:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 6:52 Yauheni Kaliuta [this message]
2016-11-11 0:14 ` [PATCH] shared: make scratchbuf_str static De Marchi, Lucas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478674346-29996-1-git-send-email-yauheni.kaliuta@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=jeyu@redhat.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).