From: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
To: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>,
linux-modules <linux-modules@vger.kernel.org>
Cc: bjorn.andersson@linaro.org, afaerber@suse.de, lucas.de.marchi@gmail.com
Subject: Re: [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles
Date: Wed, 09 Nov 2016 10:17:33 +0100 [thread overview]
Message-ID: <1478683053.4155.8.camel@suse.com> (raw)
In-Reply-To: <xunyk2cdiciy.fsf@redhat.com>
On Wed, 2016-11-09 at 04:59 +0200, Yauheni Kaliuta wrote:
> Hi!
>
> It may require more serious refactoring, since there is a problem
> with the
> approach of path recording. I can get wrong output, for example, for
> the
> following graph:
>
> /*
> mod6 -> mod7 -> mod8 -> mod9
> ^ | |
> --------------- |
> | |
> -----------------------
> */
>
> depmod: ERROR: Cycle detected: mod7 -> mod8 -> mod9 -> mod6 -> mod7
> depmod: ERROR: Cycle detected: mod6 -> mod6
> depmod: ERROR: Found 5 modules in dependency cycles!
>
>
> The problem is that the path is recorded "globally", not per vertex,
> and
> "wrong" mod6 is compared in "loop == m".
I agree and in the other thread Bjorn is mentioning kind of the same.
BR,
Yousaf
next prev parent reply other threads:[~2016-11-09 9:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 16:45 [PATCH v1 1/2] testsuite: depmod: add module dependency outside cyclic chain Mian Yousaf Kaukab
2016-11-08 16:45 ` [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles Mian Yousaf Kaukab
2016-11-09 0:40 ` Lucas De Marchi
2016-11-09 2:59 ` Yauheni Kaliuta
2016-11-09 9:17 ` Mian Yousaf Kaukab [this message]
2016-11-09 11:23 ` Yauheni Kaliuta
2016-11-11 11:43 ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
2016-11-11 11:43 ` [PATCH RFC 2/3] libkmod: list: export list handling functions Yauheni Kaliuta
2017-02-13 8:05 ` Lucas De Marchi
2017-02-20 14:22 ` Yauheni Kaliuta
2017-02-22 5:26 ` Lucas De Marchi
2017-02-22 9:41 ` [PATCH v3 0/2] Proposal for cycles handling Yauheni Kaliuta
2017-02-22 9:41 ` [PATCH v3 1/2] testsuite: depmod: check netsted loops reporting Yauheni Kaliuta
2017-02-22 9:41 ` [PATCH v3 2/2] depmod: handle nested loops Yauheni Kaliuta
2017-02-23 22:30 ` Lucas De Marchi
2016-11-11 11:43 ` [PATCH RFC 3/3] " Yauheni Kaliuta
2017-02-13 8:30 ` Lucas De Marchi
2017-02-20 14:16 ` Yauheni Kaliuta
2017-02-13 8:16 ` [PATCH RFC 0/3] Proposal for cycles handling Lucas De Marchi
2017-02-13 9:56 ` Yauheni Kaliuta
2017-02-13 8:32 ` Lucas De Marchi
2017-02-20 14:18 ` [PATCH RFC v2 0/2] " Yauheni Kaliuta
2017-02-20 14:18 ` [PATCH RFC v2 1/2] testsuite: depmod: check netsted loops reporting Yauheni Kaliuta
2017-02-20 14:19 ` [PATCH RFC v2 2/2] depmod: handle nested loops Yauheni Kaliuta
2016-11-09 0:29 ` [PATCH v1 1/2] testsuite: depmod: add module dependency outside cyclic chain Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478683053.4155.8.camel@suse.com \
--to=yousaf.kaukab@suse.com \
--cc=afaerber@suse.de \
--cc=bjorn.andersson@linaro.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=yauheni.kaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).