linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH kmod] shared/util.c: assert_cc() can only be used inside functions
Date: Mon, 5 Jun 2017 10:22:37 +0200	[thread overview]
Message-ID: <20170605102237.4dd489c2@free-electrons.com> (raw)
In-Reply-To: <CAKi4VA+3azA-8pyNS0F73d_0ahCA7=n_opwnxp9A-2Y67oLe8w@mail.gmail.com>

Hello Lucas,

Thanks for your feedback!

On Mon, 5 Jun 2017 01:04:46 -0700, Lucas De Marchi wrote:

> The changes look simple, but going forward I'd like to understand
> this. kmod requires C11 that contains _Static_assert().

kmod seems to build fine with a compiler that isn't C11.

> Is there a compelling reason to support a compiler that old? GCC 4.3.0
> has been released 9 years ago.

As you know, I'm contributing to Buildroot, an embedded Linux build
system, that allows to build from scratch lightweight, configurable
Linux systems through cross-compilation.

Buildroot is widely used in enterprise contexts, where sometimes very
old Linux distributions are used on build servers. As an example, we
even have to look at the version of the 'tar' utility available on the
host, and build our own if it's too old, because some old RHEL distros
have a tar version that is bogus.

In order to make sure our users in this situation don't face problems,
we run test builds on old distros, and one of my automated build
machine has a Debian old enough to still be based on gcc 4.3.

Of course, for the target compiler, we use something more modern (we
recently switched to gcc 6.x as our default compiler version). But the
host compiler is whatever is provided on the user's system, which we
don't control.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-06-05  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 15:03 [PATCH kmod] shared/util.c: assert_cc() can only be used inside functions Thomas Petazzoni
2017-06-05  8:04 ` Lucas De Marchi
2017-06-05  8:22   ` Thomas Petazzoni [this message]
2017-06-05 17:06     ` Lucas De Marchi
2017-06-06  7:16       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605102237.4dd489c2@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.de.marchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).