linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mkosi: allow Clear to use test modules
@ 2018-10-10 20:50 Lucas De Marchi
  2018-10-10 21:50 ` Caio Marcelo de Oliveira Filho
  0 siblings, 1 reply; 3+ messages in thread
From: Lucas De Marchi @ 2018-10-10 20:50 UTC (permalink / raw)
  To: linux-modules; +Cc: Caio Marcelo de Oliveira Filho

Now Clear has a bundle for the kernel headers, let's use it.
---
 testsuite/mkosi/mkosi.build | 9 ++-------
 testsuite/mkosi/mkosi.clear | 1 +
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/testsuite/mkosi/mkosi.build b/testsuite/mkosi/mkosi.build
index 8ed54bb..53fc797 100755
--- a/testsuite/mkosi/mkosi.build
+++ b/testsuite/mkosi/mkosi.build
@@ -29,13 +29,8 @@ rm -rf build
 mkdir build
 cd build
 
-if grep clear-linux-os /usr/lib/os-release; then
-    # Clear Linux doesn't have the dependencies for those yet.
-    echo "--disable-test-modules" > ../../.config.args
-else
-    kdir=$(find_kdir)
-    IFS=/ read _ _ _ kver _ <<<"$kdir"
-fi
+kdir=$(find_kdir)
+IFS=/ read _ _ _ kver _ <<<"$kdir"
 
 ../autogen.sh c
 make -j
diff --git a/testsuite/mkosi/mkosi.clear b/testsuite/mkosi/mkosi.clear
index 6d87514..03ba2f0 100644
--- a/testsuite/mkosi/mkosi.clear
+++ b/testsuite/mkosi/mkosi.clear
@@ -10,6 +10,7 @@ Packages=
 	os-core-update
 BuildPackages=
 	os-core-dev
+	linux-dev
 
 [Partitions]
 RootSize = 5G
-- 
2.19.1.1.g8c3cf03f71


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mkosi: allow Clear to use test modules
  2018-10-10 20:50 [PATCH] mkosi: allow Clear to use test modules Lucas De Marchi
@ 2018-10-10 21:50 ` Caio Marcelo de Oliveira Filho
  2018-10-10 21:58   ` Lucas De Marchi
  0 siblings, 1 reply; 3+ messages in thread
From: Caio Marcelo de Oliveira Filho @ 2018-10-10 21:50 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: linux-modules

On Wed, Oct 10, 2018 at 01:50:16PM -0700, Lucas De Marchi wrote:
> Now Clear has a bundle for the kernel headers, let's use it.
> ---
>  testsuite/mkosi/mkosi.build | 9 ++-------
>  testsuite/mkosi/mkosi.clear | 1 +
>  2 files changed, 3 insertions(+), 7 deletions(-)

Tested the patch with 'sudo make mkosi DISTRO=clear' and all tests
passed.

LGTM.


Caio



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mkosi: allow Clear to use test modules
  2018-10-10 21:50 ` Caio Marcelo de Oliveira Filho
@ 2018-10-10 21:58   ` Lucas De Marchi
  0 siblings, 0 replies; 3+ messages in thread
From: Lucas De Marchi @ 2018-10-10 21:58 UTC (permalink / raw)
  To: Caio Marcelo de Oliveira Filho; +Cc: Lucas De Marchi, linux-modules

On Wed, Oct 10, 2018 at 2:51 PM Caio Marcelo de Oliveira Filho
<caio.oliveira@intel.com> wrote:
>
> On Wed, Oct 10, 2018 at 01:50:16PM -0700, Lucas De Marchi wrote:
> > Now Clear has a bundle for the kernel headers, let's use it.
> > ---
> >  testsuite/mkosi/mkosi.build | 9 ++-------
> >  testsuite/mkosi/mkosi.clear | 1 +
> >  2 files changed, 3 insertions(+), 7 deletions(-)
>
> Tested the patch with 'sudo make mkosi DISTRO=clear' and all tests
> passed.
>
> LGTM.
>

applied, thanks.

Lucas De Marchi

>
> Caio
>
>


-- 
Lucas De Marchi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-10 21:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 20:50 [PATCH] mkosi: allow Clear to use test modules Lucas De Marchi
2018-10-10 21:50 ` Caio Marcelo de Oliveira Filho
2018-10-10 21:58   ` Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).