linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Cc: linux-modules@vger.kernel.org, ykaliuta@redhat.com
Subject: Re: [RFC PATCH 0/2] Unify symbol access API
Date: Wed, 19 Dec 2018 11:24:38 -0800	[thread overview]
Message-ID: <20181219192437.GE6410@ldmartin-desk.jf.intel.com> (raw)
In-Reply-To: <20181123215322.5438-1-yauheni.kaliuta@redhat.com>

On Fri, Nov 23, 2018 at 11:53:20PM +0200, Yauheni Kaliuta wrote:
> Hi!
> 
> I'm not very happy with the naming, but how do you like the idea in general?

I don't like the naming, too. The idea is good and I like the
de-duplication of the implementation, thanks.

These are all symbols, but coming from different elf sections. I wonder
if we can add a kmod_module_get_symbols2() with an additional
argument.

then we would still have kmod_module_symbol_get_symbol(),
kmod_module_symbol_get_crc() and add kmod_module_symbol_get_bind_type()

And these will need to be added to the testsuite

thoughts?

Lucas De Marchi

> 
> 
> Yauheni Kaliuta (2):
>   libkmod: module: introduce common symbol API.
>   libkmod: module: make old symbol access API as wrapper to the new
> 
>  libkmod/libkmod-module.c | 387 ++++++++++++++++-----------------------
>  libkmod/libkmod.h        |  12 ++
>  2 files changed, 171 insertions(+), 228 deletions(-)
> 
> -- 
> 2.19.1
> 

      parent reply	other threads:[~2018-12-19 19:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 21:53 [RFC PATCH 0/2] Unify symbol access API Yauheni Kaliuta
2018-11-23 21:53 ` [RFC PATCH 1/2] libkmod: module: introduce common symbol API Yauheni Kaliuta
     [not found]   ` <20181219184930.GD6410@ldmartin-desk.jf.intel.com>
2018-12-20 11:08     ` Yauheni Kaliuta
2018-11-23 21:53 ` [RFC PATCH 2/2] libkmod: module: make old symbol access API as wrapper to the new Yauheni Kaliuta
2018-12-19 19:24 ` Lucas De Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219192437.GE6410@ldmartin-desk.jf.intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=yauheni.kaliuta@redhat.com \
    --cc=ykaliuta@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).