From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96088C43381 for ; Thu, 28 Mar 2019 18:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BB2D20700 for ; Thu, 28 Mar 2019 18:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553798755; bh=1DOi8E4Cemowy8bsUMqhZziiN9iNc53NlzLS1uuKogU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gU51nJ79hyVstBU9kKD0N40M0jKctM9vzpzAEIzZaCXLDsrF6OT9o/Cj5mPO/266p kwxQktyBgLDwMv+eRrlN8eUvdOTQRxY5IO0AlXOB3pcqXVgRclYRuA/+0Wes3QvSdS YAcjic7kJ6n9bn24rwYEITVqxhiVA2h4Z0T81C1o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725885AbfC1Spu (ORCPT ); Thu, 28 Mar 2019 14:45:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:40856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbfC1Spu (ORCPT ); Thu, 28 Mar 2019 14:45:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCC5B2064A; Thu, 28 Mar 2019 18:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553798749; bh=1DOi8E4Cemowy8bsUMqhZziiN9iNc53NlzLS1uuKogU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vzp78eU2P2gd8+qA8qREVywfS2ESNlXqEt8aCeb5li6CArj9Rp+zBv6ay0I57nWfX gtJ/mPvJMfF9k45WCwTILY46eVFm0tF2uAF7vJFlhmyWCMd4LUUrP91jpSS885lU9t z2qQM5eud86yGQKBC5CEwk19aZiCHRO+HSeW74+g= Date: Thu, 28 Mar 2019 19:45:46 +0100 From: Greg KH To: Lucas De Marchi Cc: Jessica Yu , Alexey Gladkov , Masahiro Yamada , Michal Marek , Linux Kernel Mailing List , Linux Kbuild mailing list , linux-api@vger.kernel.org, "Kirill A . Shutemov" , Gleb Fotengauer-Malinovskiy , "Dmitry V. Levin" , Dmitry Torokhov , Rusty Russell , linux-modules Subject: Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file Message-ID: <20190328184546.GB23800@kroah.com> References: <20190315101013.GN8455@Legion-PC.fortress> <20190326172411.GA15936@Legion-PC.fortress> <20190327154025.GB23293@linux-8ccs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: On Thu, Mar 28, 2019 at 10:41:59AM -0700, Lucas De Marchi wrote: > On Wed, Mar 27, 2019 at 8:40 AM Jessica Yu wrote: > > >No. There are definitely not all modules. I have a builtin sha256_generic, > > >but I can't find him in the /sys/module. > > > > Yeah, you'll only find builtin modules under /sys/module/ if it has any module > > parameters, otherwise you won't find it there. As Masahiro already mentioned, > > if a builtin module has any parameters, they would be accessible under /sys/module/. > > Could we please change that and add the sysfs entry regardless of > what's being discussed here? Not having the entry there simply because > we don't have parameters for that module always annoyed me. What is the sysfs directory going to show? Will it just be empty? Feel free to send a patch for this, but from what I remember, it wasn't the easiest thing to do for some reason. But given that the code was implemented before git was, I can't quite remember. thanks, greg k-h