From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E919EC43219 for ; Mon, 29 Apr 2019 14:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8ADB2087B for ; Mon, 29 Apr 2019 14:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556547723; bh=iQv7qdfNE2ZTy8sIWEeqO2sCGSXIkTfD+az4PXbR/KQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=07Xnwhth3bP08TsWJzFWgJ5QNpF5ozap7WRdm9HqKMl1fpW+Z93Hv7M2dXbFZsU9v QL2mGDw3jjw14MUAZLLehs0nQ/OY/mxUbFUB2lIc4AoIoqHYr0XJPa5OYucWd8VyCR ctHugqbBfpUnOPEuRtnB8NJVkFwf8R1ELVlnHB0s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728292AbfD2OWD (ORCPT ); Mon, 29 Apr 2019 10:22:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:38406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728240AbfD2OWD (ORCPT ); Mon, 29 Apr 2019 10:22:03 -0400 Received: from linux-8ccs (ip5f5ade6f.dynamic.kabel-deutschland.de [95.90.222.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2E1B20673; Mon, 29 Apr 2019 14:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556547722; bh=iQv7qdfNE2ZTy8sIWEeqO2sCGSXIkTfD+az4PXbR/KQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tlVpTOyE8ff5uwR+X2Fo9yxipvxr6BB0tD7ZTU0xIYIAgeIL+iSusOHylbN/Ip0aW 8J9D/REnUqe5kGNK9WupgYLl+L2THYwe7sYigaRdw8UIqTEdEEkIEZus2n70MrsGoz GhiSIrOIjTlivm54pxLKsEVOIUHW8frEYUntptoo= Date: Mon, 29 Apr 2019 16:21:56 +0200 From: Jessica Yu To: Alexey Gladkov Cc: Masahiro Yamada , Linux Kernel Mailing List , Linux Kbuild mailing list , linux-api@vger.kernel.org, linux-modules@vger.kernel.org, "Kirill A . Shutemov" , Gleb Fotengauer-Malinovskiy , "Dmitry V. Levin" , Michal Marek , Dmitry Torokhov , Rusty Russell , Lucas De Marchi Subject: Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file Message-ID: <20190429142156.GA31567@linux-8ccs> References: <20190429090854.GU9023@dhcp129-178.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190429090854.GU9023@dhcp129-178.brq.redhat.com> X-OS: Linux linux-8ccs 5.1.0-rc1-lp150.12.28-default+ x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: +++ Alexey Gladkov [29/04/19 11:08 +0200]: >Problem: > >When a kernel module is compiled as a separate module, some important >information about the kernel module is available via .modinfo section of >the module. In contrast, when the kernel module is compiled into the >kernel, that information is not available. > >Information about built-in modules is necessary in the following cases: > >1. When it is necessary to find out what additional parameters can be >passed to the kernel at boot time. > >2. When you need to know which module names and their aliases are in >the kernel. This is very useful for creating an initrd image. > >Proposal: > >The proposed patch does not remove .modinfo section with module >information from the vmlinux at the build time and saves it into a >separate file after kernel linking. So, the kernel does not increase in >size and no additional information remains in it. Information is stored >in the same format as in the separate modules (null-terminated string >array). Because the .modinfo section is already exported with a separate >modules, we are not creating a new API. > >It can be easily read in the userspace: > >$ tr '\0' '\n' < kernel.builtin s/kernel.builtin/modules.builtin.modinfo/ Otherwise, for module.h and moduleparam.h: Acked-by: Jessica Yu And it would be great if Lucas can confirm if the file format and name would be OK for kmod. Thanks! Jessica