linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
  • * [PATCH v2 0/10] Symbol namespaces - RFC
           [not found] <20180716122125.175792-1-maco@android.com>
           [not found] ` <20180716122125.175792-3-maco@android.com>
    @ 2019-08-13 12:16 ` Matthias Maennich
      2019-08-13 12:16   ` [PATCH v2 01/10] module: support reading multiple values per modinfo tag Matthias Maennich
                         ` (10 more replies)
      2019-09-03 15:06 ` [PATCH v4 00/12] Symbol Namespaces Matthias Maennich
      2019-09-06 10:32 ` [PATCH v5 00/11] " Matthias Maennich
      3 siblings, 11 replies; 107+ messages in thread
    From: Matthias Maennich @ 2019-08-13 12:16 UTC (permalink / raw)
      To: linux-kernel, maco
      Cc: kernel-team, maennich, arnd, geert, gregkh, hpa, jeyu, joel,
    	kstewart, linux-arch, linux-kbuild, linux-m68k, linux-modules,
    	linux-scsi, linux-usb, lucas.de.marchi, maco, michal.lkml, mingo,
    	oneukum, pombredanne, sam, sboyd, sspatil, stern, tglx,
    	usb-storage, x86, yamada.masahiro, Adrian Reber, Andrew Morton,
    	Ard Biesheuvel, cocci, Dan Williams, David Howells,
    	David S. Miller, Ingo Molnar, Johannes Weiner, Jonathan Cameron,
    	Mauro Carvalho Chehab, Michael Ellerman, Nicolas Ferre,
    	Patrick Bellasi, Richard Guy Briggs, Will Deacon
    
    As of Linux 5.3-rc4, there are 31203 [1] exported symbols in the kernel.
    That is a growth of almost 1000 symbols since 4.17 (30206 [2]).  There
    seems to be some consensus amongst kernel devs that the export surface
    is too large, and hard to reason about.
    
    Generally, these symbols fall in one of these categories:
    1) Symbols actually meant for drivers
    2) Symbols that are only exported because functionality is split over
       multiple modules, yet they really shouldn't be used by modules outside
       of their own subsystem
    3) Symbols really only meant for in-tree use
    
    When module developers try to upstream their code, it regularly turns
    out that they are using exported symbols that they really shouldn't be
    using. This problem is even bigger for drivers that are currently
    out-of-tree, which may be using many symbols that they shouldn't be
    using, and that break when those symbols are removed or modified.
    
    This patch allows subsystem maintainers to partition their exported
    symbols into separate namespaces, and module authors to import such
    namespaces only when needed.
    
    This allows subsystem maintainers to more easily limit availability of
    these namespaced symbols to other parts of the kernel. It can also be
    used to partition the set of exported symbols for documentation
    purposes; for example, a set of symbols that is really only used for
    debugging could be in a "SUBSYSTEM_DEBUG" namespace.
    
    I continued the work mainly done by Martijn Coenen. In this v2 the
    following changes have been introduced compared to v1 of this series:
    
    - Rather than adding and evaluating separate sections __knsimport_NS,
      use modinfo tags to declare the namespaces a module introduces.
      Adjust modpost and the module loader accordingly.
    - Also add support for reading multiple modinfo values for the same tag
      to allow list-like access to modinfo tags.
    - The macros in export.h have been cleaned up to avoid redundancy in the
      macro parameters (ns, nspost, nspost2).
    - The introduction of relative references in the ksymtab entries caused
      a rework of the macros to accommodate that configuration as well.
    - Alignment of kernel_symbol in the ksymtab needed to be fixed to allow
      growing the kernel_symbol struct.
    - Modpost does now also append the namespace suffix to the symbol
      entries in Module.symvers.
    - The configuration option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS allows
      relaxing the enforcement of properly declared namespace imports at module
      loading time.
    - Symbols can be collectively exported into a namespace by defining
      DEFAULT_SYMBOL_NAMESPACE in the corresponding Makefile.
    - The requirement for a very recent coccinelle spatch has been lifted by
      simplifying the script.
    - nsdeps does now ensures MODULE_IMPORT_NS statements are sorted when
      patching the module source files.
    - Some minor bugs have been addressed in nsdeps to allow it to work with
      modules that have more than one source file.
    - The RFC for the usb-storage symbols has been simplified by using
      DEFAULT_SYMBOL_NAMESPACE=USB_STORAGE rather than explicitly exporting each
      and every symbol into that new namespace.
    
    This patch series was developed against v5.3-rc4.
    
    [1] git grep "^EXPORT_SYMBOL\w*(" v5.3-rc4 | wc -l
    [2] git grep "^EXPORT_SYMBOL\w*(" v4.17    | wc -l
    
    Matthias Maennich (10):
      module: support reading multiple values per modinfo tag
      export: explicitly align struct kernel_symbol
      module: add support for symbol namespaces.
      modpost: add support for symbol namespaces
      module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS
      export: allow definition default namespaces in Makefiles or sources
      modpost: add support for generating namespace dependencies
      scripts: Coccinelle script for namespace dependencies.
      usb-storage: remove single-use define for debugging
      RFC: usb-storage: export symbols in USB_STORAGE namespace
    
     MAINTAINERS                                 |   5 +
     Makefile                                    |  12 ++
     arch/m68k/include/asm/export.h              |   1 -
     drivers/usb/storage/Makefile                |   2 +
     drivers/usb/storage/alauda.c                |   1 +
     drivers/usb/storage/cypress_atacb.c         |   1 +
     drivers/usb/storage/datafab.c               |   1 +
     drivers/usb/storage/debug.h                 |   2 -
     drivers/usb/storage/ene_ub6250.c            |   1 +
     drivers/usb/storage/freecom.c               |   1 +
     drivers/usb/storage/isd200.c                |   1 +
     drivers/usb/storage/jumpshot.c              |   1 +
     drivers/usb/storage/karma.c                 |   1 +
     drivers/usb/storage/onetouch.c              |   1 +
     drivers/usb/storage/realtek_cr.c            |   1 +
     drivers/usb/storage/scsiglue.c              |   2 +-
     drivers/usb/storage/sddr09.c                |   1 +
     drivers/usb/storage/sddr55.c                |   1 +
     drivers/usb/storage/shuttle_usbat.c         |   1 +
     drivers/usb/storage/uas.c                   |   1 +
     include/asm-generic/export.h                |  14 +-
     include/linux/export.h                      |  92 +++++++++++--
     include/linux/module.h                      |   2 +
     init/Kconfig                                |  14 ++
     kernel/module.c                             |  67 ++++++++-
     scripts/Makefile.modpost                    |   4 +-
     scripts/coccinelle/misc/add_namespace.cocci |  23 ++++
     scripts/mod/modpost.c                       | 144 ++++++++++++++++++--
     scripts/mod/modpost.h                       |   9 ++
     scripts/nsdeps                              |  54 ++++++++
     30 files changed, 421 insertions(+), 40 deletions(-)
     create mode 100644 scripts/coccinelle/misc/add_namespace.cocci
     create mode 100644 scripts/nsdeps
    
    -- 
    2.23.0.rc1.153.gdeed80330f-goog
    
    
    ^ permalink raw reply	[flat|nested] 107+ messages in thread
  • * [PATCH v4 00/12] Symbol Namespaces
           [not found] <20180716122125.175792-1-maco@android.com>
           [not found] ` <20180716122125.175792-3-maco@android.com>
      2019-08-13 12:16 ` [PATCH v2 0/10] Symbol namespaces - RFC Matthias Maennich
    @ 2019-09-03 15:06 ` Matthias Maennich
      2019-09-03 15:06   ` [PATCH v4 01/12] module: support reading multiple values per modinfo tag Matthias Maennich
                         ` (12 more replies)
      2019-09-06 10:32 ` [PATCH v5 00/11] " Matthias Maennich
      3 siblings, 13 replies; 107+ messages in thread
    From: Matthias Maennich @ 2019-09-03 15:06 UTC (permalink / raw)
      To: linux-kernel
      Cc: kernel-team, maennich, arnd, gregkh, jeyu, joel, lucas.de.marchi,
    	maco, sspatil, will, yamada.masahiro, linux-kbuild,
    	linux-modules, linux-usb, usb-storage, linux-watchdog
    
    As of Linux 5.3-rc7, there are 31207 [1] exported symbols in the kernel.
    That is a growth of roughly 1000 symbols since 4.17 (30206 [2]). There
    seems to be some consensus amongst kernel devs that the export surface
    is too large, and hard to reason about.
    
    Generally, these symbols fall in one of these categories:
    1) Symbols actually meant for drivers
    2) Symbols that are only exported because functionality is split over
       multiple modules, yet they really shouldn't be used by modules outside
       of their own subsystem
    3) Symbols really only meant for in-tree use
    
    When module developers try to upstream their code, it regularly turns
    out that they are using exported symbols that they really shouldn't be
    using. This problem is even bigger for drivers that are currently
    out-of-tree, which may be using many symbols that they shouldn't be
    using, and that break when those symbols are removed or modified.
    
    This patch allows subsystem maintainers to partition their exported
    symbols into separate namespaces, and module authors to import such
    namespaces only when needed.
    
    This allows subsystem maintainers to more easily limit availability of
    these namespaced symbols to other parts of the kernel. It can also be
    used to partition the set of exported symbols for documentation
    purposes; for example, a set of symbols that is really only used for
    debugging could be in a "SUBSYSTEM_DEBUG" namespace.
    
    The series contains two RFC patches that do not need to be merged along
    with the rest of the series, but they serve as a reference for using the
    symbol namespaces. Especially, the watchdog subsystem might not be
    affected by the issues addressed by Symbol Namespaces. I left the patch
    in for reference anyway for demonstration purposes.
    
    I continued the work mainly done by Martijn Coenen.
    
    Changes in v2:
    - Rather than adding and evaluating separate sections __knsimport_NS,
      use modinfo tags to declare the namespaces a module introduces.
      Adjust modpost and the module loader accordingly.
    - Also add support for reading multiple modinfo values for the same tag
      to allow list-like access to modinfo tags.
    - The macros in export.h have been cleaned up to avoid redundancy in the
      macro parameters (ns, nspost, nspost2).
    - The introduction of relative references in the ksymtab entries caused
      a rework of the macros to accommodate that configuration as well.
    - Alignment of kernel_symbol in the ksymtab needed to be fixed to allow
      growing the kernel_symbol struct.
    - Modpost does now also append the namespace suffix to the symbol
      entries in Module.symvers.
    - The configuration option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS allows
      relaxing the enforcement of properly declared namespace imports at
      module loading time.
    - Symbols can be collectively exported into a namespace by defining
      DEFAULT_SYMBOL_NAMESPACE in the corresponding Makefile.
    - The requirement for a very recent coccinelle spatch has been lifted by
      simplifying the script.
    - nsdeps does now ensures MODULE_IMPORT_NS statements are sorted when
      patching the module source files.
    - Some minor bugs have been addressed in nsdeps to allow it to work with
      modules that have more than one source file.
    - The RFC for the usb-storage symbols has been simplified by using
      DEFAULT_SYMBOL_NAMESPACE=USB_STORAGE rather than explicitly exporting
      each and every symbol into that new namespace.
    
    Changes in v3:
    - Reword the documentation for the
      MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS option for clarification.
    - Fix printed required version of spatch in coccinelle script.
    - Adopt kbuild changes for modpost: .mod files are no longer generated
      in .tmp_versions. Similarely, generate the .ns_deps files in the tree
      along with the .mod files. Also, nsdeps now uses modules.order as
      source for the list modules to consider.
    - Add an RFC patch to introduce the namespace WATCHDOG_CORE for symbols
      exported in watchdog_core.c.
    
    Changes in v4:
    - scripts/nsdeps:
      - exit on first error
      - support out-of-tree builds O=...
    - scripts/mod/modpost: make the namespace a separate field when
      exporting to Module.symvers (rather than symbol.NS)
    - scripts/export_report.pl: update for new Module.symvers format
    - include/linux/export.h: fixed style nits
    - kernel/module.c: ensure namespaces are imported before taking a
      reference to the owner module
    - Documentation: document the Symbol Namespace feature and update
      references to Module.symvers and EXPORT_SYMBOL*
    
    This patch series was developed against v5.3-rc7.
    
    [1] git grep "^EXPORT_SYMBOL\w*(" v5.3-rc7 | wc -l
    [2] git grep "^EXPORT_SYMBOL\w*(" v4.17    | wc -l
    
    Cc: arnd@arndb.de
    Cc: gregkh@linuxfoundation.org
    Cc: jeyu@kernel.org
    Cc: joel@joelfernandes.org
    Cc: lucas.de.marchi@gmail.com
    Cc: maco@android.com
    Cc: sspatil@google.com
    Cc: will@kernel.org
    Cc: yamada.masahiro@socionext.com
    Cc: linux-kbuild@vger.kernel.org
    Cc: linux-modules@vger.kernel.org
    Cc: linux-usb@vger.kernel.org
    Cc: usb-storage@lists.one-eyed-alien.net
    Cc: linux-watchdog@vger.kernel.org
    
    
    Matthias Maennich (12):
      module: support reading multiple values per modinfo tag
      export: explicitly align struct kernel_symbol
      module: add support for symbol namespaces.
      modpost: add support for symbol namespaces
      module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS
      export: allow definition default namespaces in Makefiles or sources
      modpost: add support for generating namespace dependencies
      scripts: Coccinelle script for namespace dependencies.
      docs: Add documentation for Symbol Namespaces
      usb-storage: remove single-use define for debugging
      RFC: usb-storage: export symbols in USB_STORAGE namespace
      RFC: watchdog: export core symbols in WATCHDOG_CORE namespace
    
     .gitignore                                  |   1 +
     Documentation/kbuild/modules.rst            |   7 +-
     Documentation/kbuild/namespaces.rst         | 154 ++++++++++++++++++++
     Documentation/kernel-hacking/hacking.rst    |  18 +++
     MAINTAINERS                                 |   5 +
     Makefile                                    |  14 +-
     arch/m68k/include/asm/export.h              |   1 -
     drivers/hwmon/ftsteutates.c                 |   1 +
     drivers/hwmon/sch56xx-common.c              |   1 +
     drivers/rtc/rtc-abx80x.c                    |   1 +
     drivers/usb/storage/Makefile                |   2 +
     drivers/usb/storage/alauda.c                |   1 +
     drivers/usb/storage/cypress_atacb.c         |   1 +
     drivers/usb/storage/datafab.c               |   1 +
     drivers/usb/storage/debug.h                 |   2 -
     drivers/usb/storage/ene_ub6250.c            |   1 +
     drivers/usb/storage/freecom.c               |   1 +
     drivers/usb/storage/isd200.c                |   1 +
     drivers/usb/storage/jumpshot.c              |   1 +
     drivers/usb/storage/karma.c                 |   1 +
     drivers/usb/storage/onetouch.c              |   1 +
     drivers/usb/storage/realtek_cr.c            |   1 +
     drivers/usb/storage/scsiglue.c              |   2 +-
     drivers/usb/storage/sddr09.c                |   1 +
     drivers/usb/storage/sddr55.c                |   1 +
     drivers/usb/storage/shuttle_usbat.c         |   1 +
     drivers/usb/storage/uas.c                   |   1 +
     drivers/watchdog/armada_37xx_wdt.c          |   1 +
     drivers/watchdog/asm9260_wdt.c              |   1 +
     drivers/watchdog/aspeed_wdt.c               |   1 +
     drivers/watchdog/at91sam9_wdt.c             |   1 +
     drivers/watchdog/atlas7_wdt.c               |   1 +
     drivers/watchdog/bcm2835_wdt.c              |   1 +
     drivers/watchdog/bcm47xx_wdt.c              |   1 +
     drivers/watchdog/bcm7038_wdt.c              |   1 +
     drivers/watchdog/bcm_kona_wdt.c             |   1 +
     drivers/watchdog/bd70528_wdt.c              |   1 +
     drivers/watchdog/cadence_wdt.c              |   1 +
     drivers/watchdog/da9052_wdt.c               |   1 +
     drivers/watchdog/da9055_wdt.c               |   1 +
     drivers/watchdog/da9062_wdt.c               |   1 +
     drivers/watchdog/da9063_wdt.c               |   1 +
     drivers/watchdog/davinci_wdt.c              |   1 +
     drivers/watchdog/digicolor_wdt.c            |   1 +
     drivers/watchdog/dw_wdt.c                   |   1 +
     drivers/watchdog/ebc-c384_wdt.c             |   1 +
     drivers/watchdog/ep93xx_wdt.c               |   1 +
     drivers/watchdog/ftwdt010_wdt.c             |   1 +
     drivers/watchdog/gpio_wdt.c                 |   1 +
     drivers/watchdog/hpwdt.c                    |   1 +
     drivers/watchdog/i6300esb.c                 |   1 +
     drivers/watchdog/iTCO_wdt.c                 |   1 +
     drivers/watchdog/ie6xx_wdt.c                |   1 +
     drivers/watchdog/imgpdc_wdt.c               |   1 +
     drivers/watchdog/imx2_wdt.c                 |   1 +
     drivers/watchdog/intel-mid_wdt.c            |   1 +
     drivers/watchdog/it87_wdt.c                 |   1 +
     drivers/watchdog/kempld_wdt.c               |   1 +
     drivers/watchdog/lpc18xx_wdt.c              |   1 +
     drivers/watchdog/max63xx_wdt.c              |   1 +
     drivers/watchdog/max77620_wdt.c             |   1 +
     drivers/watchdog/mei_wdt.c                  |   1 +
     drivers/watchdog/mena21_wdt.c               |   1 +
     drivers/watchdog/menf21bmc_wdt.c            |   1 +
     drivers/watchdog/menz69_wdt.c               |   1 +
     drivers/watchdog/meson_gxbb_wdt.c           |   1 +
     drivers/watchdog/meson_wdt.c                |   1 +
     drivers/watchdog/mlx_wdt.c                  |   1 +
     drivers/watchdog/moxart_wdt.c               |   1 +
     drivers/watchdog/mtk_wdt.c                  |   1 +
     drivers/watchdog/ni903x_wdt.c               |   1 +
     drivers/watchdog/nic7018_wdt.c              |   1 +
     drivers/watchdog/npcm_wdt.c                 |   1 +
     drivers/watchdog/of_xilinx_wdt.c            |   1 +
     drivers/watchdog/omap_wdt.c                 |   1 +
     drivers/watchdog/pm8916_wdt.c               |   1 +
     drivers/watchdog/qcom-wdt.c                 |   1 +
     drivers/watchdog/rave-sp-wdt.c              |   1 +
     drivers/watchdog/renesas_wdt.c              |   1 +
     drivers/watchdog/retu_wdt.c                 |   1 +
     drivers/watchdog/rn5t618_wdt.c              |   1 +
     drivers/watchdog/rza_wdt.c                  |   1 +
     drivers/watchdog/s3c2410_wdt.c              |   1 +
     drivers/watchdog/sama5d4_wdt.c              |   1 +
     drivers/watchdog/sirfsoc_wdt.c              |   1 +
     drivers/watchdog/softdog.c                  |   1 +
     drivers/watchdog/sp5100_tco.c               |   1 +
     drivers/watchdog/sprd_wdt.c                 |   1 +
     drivers/watchdog/st_lpc_wdt.c               |   1 +
     drivers/watchdog/stmp3xxx_rtc_wdt.c         |   1 +
     drivers/watchdog/stpmic1_wdt.c              |   1 +
     drivers/watchdog/sunxi_wdt.c                |   1 +
     drivers/watchdog/tangox_wdt.c               |   1 +
     drivers/watchdog/tegra_wdt.c                |   1 +
     drivers/watchdog/tqmx86_wdt.c               |   1 +
     drivers/watchdog/ts4800_wdt.c               |   1 +
     drivers/watchdog/ts72xx_wdt.c               |   1 +
     drivers/watchdog/twl4030_wdt.c              |   1 +
     drivers/watchdog/uniphier_wdt.c             |   1 +
     drivers/watchdog/via_wdt.c                  |   1 +
     drivers/watchdog/w83627hf_wdt.c             |   1 +
     drivers/watchdog/watchdog_core.c            |  10 +-
     drivers/watchdog/wdat_wdt.c                 |   1 +
     drivers/watchdog/wm831x_wdt.c               |   1 +
     drivers/watchdog/wm8350_wdt.c               |   1 +
     drivers/watchdog/xen_wdt.c                  |   1 +
     drivers/watchdog/ziirave_wdt.c              |   1 +
     include/asm-generic/export.h                |  14 +-
     include/linux/export.h                      |  98 +++++++++++--
     include/linux/module.h                      |   2 +
     init/Kconfig                                |  13 ++
     kernel/module.c                             |  67 ++++++++-
     scripts/Makefile.modpost                    |   4 +-
     scripts/coccinelle/misc/add_namespace.cocci |  23 +++
     scripts/export_report.pl                    |   2 +-
     scripts/mod/modpost.c                       | 150 ++++++++++++++++---
     scripts/mod/modpost.h                       |   9 ++
     scripts/nsdeps                              |  60 ++++++++
     118 files changed, 697 insertions(+), 57 deletions(-)
     create mode 100644 Documentation/kbuild/namespaces.rst
     create mode 100644 scripts/coccinelle/misc/add_namespace.cocci
     create mode 100644 scripts/nsdeps
    
    -- 
    2.23.0.187.g17f5b7556c-goog
    
    
    ^ permalink raw reply	[flat|nested] 107+ messages in thread
  • * [PATCH v5 00/11] Symbol Namespaces
           [not found] <20180716122125.175792-1-maco@android.com>
                       ` (2 preceding siblings ...)
      2019-09-03 15:06 ` [PATCH v4 00/12] Symbol Namespaces Matthias Maennich
    @ 2019-09-06 10:32 ` Matthias Maennich
      2019-09-06 10:32   ` [PATCH v5 01/11] module: support reading multiple values per modinfo tag Matthias Maennich
                         ` (11 more replies)
      3 siblings, 12 replies; 107+ messages in thread
    From: Matthias Maennich @ 2019-09-06 10:32 UTC (permalink / raw)
      To: linux-kernel
      Cc: kernel-team, maennich, arnd, gregkh, jeyu, joel, lucas.de.marchi,
    	maco, sspatil, will, yamada.masahiro, linux-kbuild,
    	linux-modules, linux-usb, usb-storage
    
    As of Linux 5.3-rc7, there are 31207 [1] exported symbols in the kernel.
    That is a growth of roughly 1000 symbols since 4.17 (30206 [2]). There
    seems to be some consensus amongst kernel devs that the export surface
    is too large, and hard to reason about.
    
    Generally, these symbols fall in one of these categories:
    1) Symbols actually meant for drivers
    2) Symbols that are only exported because functionality is split over
       multiple modules, yet they really shouldn't be used by modules outside
       of their own subsystem
    3) Symbols really only meant for in-tree use
    
    When module developers try to upstream their code, it regularly turns
    out that they are using exported symbols that they really shouldn't be
    using. This problem is even bigger for drivers that are currently
    out-of-tree, which may be using many symbols that they shouldn't be
    using, and that break when those symbols are removed or modified.
    
    This patch allows subsystem maintainers to partition their exported
    symbols into separate namespaces, and module authors to import such
    namespaces only when needed.
    
    This allows subsystem maintainers to more easily limit availability of
    these namespaced symbols to other parts of the kernel. It can also be
    used to partition the set of exported symbols for documentation
    purposes; for example, a set of symbols that is really only used for
    debugging could be in a "SUBSYSTEM_DEBUG" namespace.
    
    I continued the work mainly done by Martijn Coenen.
    
    Changes in v2:
    - Rather than adding and evaluating separate sections __knsimport_NS,
      use modinfo tags to declare the namespaces a module introduces.
      Adjust modpost and the module loader accordingly.
    - Also add support for reading multiple modinfo values for the same tag
      to allow list-like access to modinfo tags.
    - The macros in export.h have been cleaned up to avoid redundancy in the
      macro parameters (ns, nspost, nspost2).
    - The introduction of relative references in the ksymtab entries caused
      a rework of the macros to accommodate that configuration as well.
    - Alignment of kernel_symbol in the ksymtab needed to be fixed to allow
      growing the kernel_symbol struct.
    - Modpost does now also append the namespace suffix to the symbol
      entries in Module.symvers.
    - The configuration option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS allows
      relaxing the enforcement of properly declared namespace imports at
      module loading time.
    - Symbols can be collectively exported into a namespace by defining
      DEFAULT_SYMBOL_NAMESPACE in the corresponding Makefile.
    - The requirement for a very recent coccinelle spatch has been lifted by
      simplifying the script.
    - nsdeps does now ensures MODULE_IMPORT_NS statements are sorted when
      patching the module source files.
    - Some minor bugs have been addressed in nsdeps to allow it to work with
      modules that have more than one source file.
    - The RFC for the usb-storage symbols has been simplified by using
      DEFAULT_SYMBOL_NAMESPACE=USB_STORAGE rather than explicitly exporting
      each and every symbol into that new namespace.
    
    Changes in v3:
    - Reword the documentation for the
      MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS option for clarification.
    - Fix printed required version of spatch in coccinelle script.
    - Adopt kbuild changes for modpost: .mod files are no longer generated
      in .tmp_versions. Similarely, generate the .ns_deps files in the tree
      along with the .mod files. Also, nsdeps now uses modules.order as
      source for the list modules to consider.
    - Add an RFC patch to introduce the namespace WATCHDOG_CORE for symbols
      exported in watchdog_core.c.
    
    Changes in v4:
    - scripts/nsdeps:
      - exit on first error
      - support out-of-tree builds O=...
    - scripts/export_report.pl: update for new Module.symvers format
    - scripts/mod/modpost: make the namespace a separate field when
      exporting to Module.symvers (rather than symbol.NS)
    - include/linux/export.h: fixed style nits
    - kernel/module.c: ensure namespaces are imported before taking a
      reference to the owner module
    - Documentation: document the Symbol Namespace feature and update
      references to Module.symvers and EXPORT_SYMBOL*
    
    Changes in v5:
    - Makefile: let 'nsdeps' depend on 'modules' to allow
      `make clean; make nsdeps` to work
    - scripts/nsdeps: drop 'exit on first error' again as it just makes more
      problems than it solves
    - drop the watchdog RFC patch for now
    
    This patch series was developed against v5.3-rc7.
    
    [1] git grep "^EXPORT_SYMBOL\w*(" v5.3-rc7 | wc -l
    [2] git grep "^EXPORT_SYMBOL\w*(" v4.17    | wc -l
    
    Cc: arnd@arndb.de
    Cc: gregkh@linuxfoundation.org
    Cc: jeyu@kernel.org
    Cc: joel@joelfernandes.org
    Cc: lucas.de.marchi@gmail.com
    Cc: maco@android.com
    Cc: sspatil@google.com
    Cc: will@kernel.org
    Cc: yamada.masahiro@socionext.com
    Cc: linux-kbuild@vger.kernel.org
    Cc: linux-modules@vger.kernel.org
    Cc: linux-usb@vger.kernel.org
    Cc: usb-storage@lists.one-eyed-alien.net
    Cc: kernel-team@android.com
    
    Matthias Maennich (11):
      module: support reading multiple values per modinfo tag
      export: explicitly align struct kernel_symbol
      module: add support for symbol namespaces.
      modpost: add support for symbol namespaces
      module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS
      export: allow definition default namespaces in Makefiles or sources
      modpost: add support for generating namespace dependencies
      scripts: Coccinelle script for namespace dependencies.
      docs: Add documentation for Symbol Namespaces
      usb-storage: remove single-use define for debugging
      usb-storage: export symbols in USB_STORAGE namespace
    
     .gitignore                                  |   1 +
     Documentation/kbuild/modules.rst            |   7 +-
     Documentation/kbuild/namespaces.rst         | 154 ++++++++++++++++++++
     Documentation/kernel-hacking/hacking.rst    |  18 +++
     MAINTAINERS                                 |   5 +
     Makefile                                    |  14 +-
     arch/m68k/include/asm/export.h              |   1 -
     drivers/usb/storage/Makefile                |   2 +
     drivers/usb/storage/alauda.c                |   1 +
     drivers/usb/storage/cypress_atacb.c         |   1 +
     drivers/usb/storage/datafab.c               |   1 +
     drivers/usb/storage/debug.h                 |   2 -
     drivers/usb/storage/ene_ub6250.c            |   1 +
     drivers/usb/storage/freecom.c               |   1 +
     drivers/usb/storage/isd200.c                |   1 +
     drivers/usb/storage/jumpshot.c              |   1 +
     drivers/usb/storage/karma.c                 |   1 +
     drivers/usb/storage/onetouch.c              |   1 +
     drivers/usb/storage/realtek_cr.c            |   1 +
     drivers/usb/storage/scsiglue.c              |   2 +-
     drivers/usb/storage/sddr09.c                |   1 +
     drivers/usb/storage/sddr55.c                |   1 +
     drivers/usb/storage/shuttle_usbat.c         |   1 +
     drivers/usb/storage/uas.c                   |   1 +
     include/asm-generic/export.h                |  14 +-
     include/linux/export.h                      |  98 +++++++++++--
     include/linux/module.h                      |   2 +
     init/Kconfig                                |  13 ++
     kernel/module.c                             |  67 ++++++++-
     scripts/Makefile.modpost                    |   4 +-
     scripts/coccinelle/misc/add_namespace.cocci |  23 +++
     scripts/export_report.pl                    |   2 +-
     scripts/mod/modpost.c                       | 150 ++++++++++++++++---
     scripts/mod/modpost.h                       |   9 ++
     scripts/nsdeps                              |  58 ++++++++
     35 files changed, 608 insertions(+), 52 deletions(-)
     create mode 100644 Documentation/kbuild/namespaces.rst
     create mode 100644 scripts/coccinelle/misc/add_namespace.cocci
     create mode 100644 scripts/nsdeps
    
    -- 
    2.23.0.187.g17f5b7556c-goog
    
    
    ^ permalink raw reply	[flat|nested] 107+ messages in thread

  • end of thread, other threads:[~2019-09-09  8:35 UTC | newest]
    
    Thread overview: 107+ messages (download: mbox.gz / follow: Atom feed)
    -- links below jump to the message on this page --
         [not found] <20180716122125.175792-1-maco@android.com>
         [not found] ` <20180716122125.175792-3-maco@android.com>
         [not found]   ` <CAB0TPYEOVHcFGFLTjVvk7R0VSgSnXZRi1PjSYXONJSjqd4NewQ@mail.gmail.com>
         [not found]     ` <20180725155507.umb5oatduquxwlmt@linux-8ccs>
    2018-07-25 16:48       ` [PATCH 2/6] module: add support for symbol namespaces Lucas De Marchi
    2018-07-26  7:44         ` Martijn Coenen
    2019-08-13 12:16 ` [PATCH v2 0/10] Symbol namespaces - RFC Matthias Maennich
    2019-08-13 12:16   ` [PATCH v2 01/10] module: support reading multiple values per modinfo tag Matthias Maennich
    2019-08-13 12:40     ` Greg KH
    2019-08-13 12:16   ` [PATCH v2 02/10] export: explicitly align struct kernel_symbol Matthias Maennich
    2019-08-13 12:41     ` Greg KH
    2019-08-13 12:17   ` [PATCH v2 03/10] module: add support for symbol namespaces Matthias Maennich
    2019-08-13 15:26     ` Greg KH
    2019-08-13 12:17   ` [PATCH v2 04/10] modpost: " Matthias Maennich
    2019-08-13 15:27     ` Greg KH
    2019-08-13 12:17   ` [PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
    2019-08-13 18:17     ` Greg KH
    2019-08-13 20:15     ` Saravana Kannan
    2019-08-14 12:54       ` Matthias Maennich
    2019-08-14 17:34         ` Saravana Kannan
    2019-08-13 12:17   ` [PATCH v2 06/10] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
    2019-08-13 18:16     ` Greg KH
    2019-08-13 18:16     ` Greg KH
    2019-08-13 12:17   ` [PATCH v2 07/10] modpost: add support for generating namespace dependencies Matthias Maennich
    2019-08-13 18:21     ` Greg KH
    2019-08-13 12:17   ` [PATCH v2 08/10] scripts: Coccinelle script for " Matthias Maennich
    2019-08-13 12:31     ` Julia Lawall
    2019-08-13 12:44     ` Greg KH
    2019-08-14  6:36     ` [Cocci] " Himanshu Jha
    2019-08-14  8:03       ` Matthias Maennich
    2019-08-14 12:00     ` [v2 " Markus Elfring
    2019-08-15 13:50     ` Markus Elfring
    2019-08-22  9:18       ` Matthias Maennich
    2019-08-22 11:00         ` Markus Elfring
    2019-08-13 12:17   ` [PATCH v2 09/10] usb-storage: remove single-use define for debugging Matthias Maennich
    2019-08-13 12:42     ` Greg KH
    2019-08-13 13:12       ` Greg KH
    2019-08-13 12:17   ` [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
    2019-08-13 12:45     ` Greg KH
    2019-08-13 12:47     ` Greg KH
    2019-08-13 15:02       ` Matthias Maennich
         [not found]   ` <20190821114955.12788-1-maennich@google.com>
    2019-08-21 11:49     ` [PATCH v3 01/11] module: support reading multiple values per modinfo tag Matthias Maennich
    2019-08-21 11:49     ` [PATCH v3 02/11] export: explicitly align struct kernel_symbol Matthias Maennich
    2019-08-21 11:49     ` [PATCH v3 03/11] module: add support for symbol namespaces Matthias Maennich
    2019-08-27 15:37       ` Jessica Yu
    2019-08-27 16:04         ` Matthias Maennich
    2019-08-21 11:49     ` [PATCH v3 04/11] modpost: " Matthias Maennich
    2019-08-26 16:21       ` Jessica Yu
    2019-08-27 14:41         ` Matthias Maennich
    2019-08-28  9:43           ` Jessica Yu
    2019-08-28  9:55             ` Matthias Maennich
    2019-08-28 10:16               ` Jessica Yu
    2019-08-21 11:49     ` [PATCH v3 05/11] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
    2019-08-21 11:49     ` [PATCH v3 06/11] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
    2019-08-28 10:49       ` Jessica Yu
    2019-08-28 10:56         ` Matthias Maennich
    2019-08-21 11:49     ` [PATCH v3 07/11] modpost: add support for generating namespace dependencies Matthias Maennich
    2019-08-21 11:49     ` [PATCH v3 08/11] scripts: Coccinelle script for " Matthias Maennich
    2019-08-22  6:09       ` [v3 " Markus Elfring
    2019-08-29 12:13       ` [PATCH v3 " Jessica Yu
    2019-08-21 11:49     ` [PATCH v3 09/11] usb-storage: remove single-use define for debugging Matthias Maennich
    2019-08-21 12:37       ` Greg KH
    2019-08-21 13:21       ` Thomas Gleixner
    2019-08-21 13:32         ` Greg KH
    2019-08-21 11:49     ` [PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
    2019-08-21 12:38       ` Greg KH
    2019-08-21 14:36         ` Jessica Yu
    2019-08-21 23:13       ` Christoph Hellwig
    2019-08-22  8:32         ` Matthias Maennich
    2019-09-03 15:06 ` [PATCH v4 00/12] Symbol Namespaces Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 01/12] module: support reading multiple values per modinfo tag Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 02/12] export: explicitly align struct kernel_symbol Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 03/12] module: add support for symbol namespaces Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 04/12] modpost: " Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 05/12] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 06/12] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 07/12] modpost: add support for generating namespace dependencies Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 08/12] scripts: Coccinelle script for " Matthias Maennich
    2019-09-04  9:53     ` Masahiro Yamada
    2019-09-05 14:46       ` Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 09/12] docs: Add documentation for Symbol Namespaces Matthias Maennich
    2019-09-04  7:16     ` Greg KH
    2019-09-03 15:06   ` [PATCH v4 10/12] usb-storage: remove single-use define for debugging Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 11/12] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
    2019-09-03 15:06   ` [PATCH v4 12/12] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Matthias Maennich
    2019-09-03 16:10     ` Guenter Roeck
    2019-09-04  8:45       ` Masahiro Yamada
    2019-09-04 12:12         ` Guenter Roeck
    2019-09-04 16:16           ` [usb-storage] " Matthew Dharm
    2019-09-05 10:41             ` Jessica Yu
    2019-09-05 10:52               ` Arnd Bergmann
    2019-09-05 11:16                 ` Jessica Yu
    2019-09-05 11:25                   ` Masahiro Yamada
    2019-09-05 12:00                     ` Greg Kroah-Hartman
    2019-09-05 11:25               ` Matthias Maennich
    2019-09-04  9:37   ` [PATCH v4 00/12] Symbol Namespaces Masahiro Yamada
    2019-09-06 10:32 ` [PATCH v5 00/11] " Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 01/11] module: support reading multiple values per modinfo tag Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 02/11] export: explicitly align struct kernel_symbol Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 03/11] module: add support for symbol namespaces Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 04/11] modpost: " Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 05/11] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 06/11] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 07/11] modpost: add support for generating namespace dependencies Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 08/11] scripts: Coccinelle script for " Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 09/11] docs: Add documentation for Symbol Namespaces Matthias Maennich
    2019-09-06 10:32   ` [PATCH v5 10/11] usb-storage: remove single-use define for debugging Matthias Maennich
    2019-09-06 12:59     ` Jessica Yu
    2019-09-06 13:22       ` Greg KH
    2019-09-06 10:32   ` [PATCH v5 11/11] usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
    2019-09-09  8:35   ` [PATCH v5 00/11] Symbol Namespaces Jessica Yu
    

    This is a public inbox, see mirroring instructions
    for how to clone and mirror all data and code used for this inbox;
    as well as URLs for NNTP newsgroup(s).