archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <>
To: Jorge Lucangeli Obes <>
Subject: Re: Buffer overflow in modprobe
Date: Wed, 18 Dec 2019 16:45:38 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Dec 12, 2019 at 02:16:18PM -0500, Jorge Lucangeli Obes wrote:
>Reset the state of was_space to false between passes.
>For your assistance, we have provided the following code:
>--- libkmod-config.c            2018-06-21 17:59:48.633600181 +0100
>+++ libkmod-config.fixed        2018-09-12 21:42:34.499453017 +0100 @@
>-333,6 +333,8 @@
>                memcpy(dep->name ,modname ,modnamelen);
>+        was_space = false;
>+               /* copy strings */

this looks reasonable. Are you the author of such change? Could you send
this as a patch with git send-email?

It would be nice to have a test added to the testsuite too if you can.

Lucas De Marchi

>               itr = dep->name + modnamelen;
>               n_pre = 0;

  reply	other threads:[~2019-12-19  0:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 19:16 Buffer overflow in modprobe Jorge Lucangeli Obes
2019-12-19  0:45 ` Lucas De Marchi [this message]
2019-12-19 19:48   ` Jorge Lucangeli Obes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).