From: Jessica Yu <jeyu@kernel.org>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Matthias Maennich <maennich@google.com>, linux-modules@vger.kernel.org
Subject: Re: [PATCH] depmod: account for new namespace field in Module.symvers (for kernel versions >= 5.4)
Date: Tue, 3 Mar 2020 15:31:09 +0100 [thread overview]
Message-ID: <20200303143109.GA18979@linux-8ccs> (raw)
In-Reply-To: <20200221165243.25100-1-jeyu@kernel.org>
+++ Jessica Yu [21/02/20 17:52 +0100]:
>depmod -e -E is broken for kernel versions >= 5.4, because a new
>namespace field was added to Module.symvers. Each line is tab delimited
>with 5 fields in total. E.g.,
>
> 0xb352177e\tfind_first_bit\tnamespace\tvmlinux\tEXPORT_SYMBOL
>
>When a symbol doesn't have a namespace, then the namespace field is empty:
>
> 0xb352177e\tfind_first_bit\t\tvmlinux\tEXPORT_SYMBOL
>
>Fix up depmod_load_symvers() so it finds the crc, symbol, and module
>("where") fields correctly. Since there can be empty fields, strsep() is
>used instead of strtok(), since strtok() cannot handle empty fields
>(i.e., two delimiters in succession).
>
>Signed-off-by: Jessica Yu <jeyu@kernel.org>
Friendly ping? :-)
Thanks,
Jessica
next prev parent reply other threads:[~2020-03-03 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:52 [PATCH] depmod: account for new namespace field in Module.symvers (for kernel versions >= 5.4) Jessica Yu
2020-03-03 14:31 ` Jessica Yu [this message]
2020-03-04 6:28 ` Lucas De Marchi
2020-03-04 9:18 ` Jessica Yu
2020-03-04 11:34 ` Matthias Maennich
2020-03-06 0:10 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303143109.GA18979@linux-8ccs \
--to=jeyu@kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).