Linux-Modules Archive on lore.kernel.org
 help / color / Atom feed
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules@vger.kernel.org, Yanko Kaneti <yaneti@declera.com>
Subject: Re: [PATCH 2/2] depmod: just add .bin suffix to builtin.modinfo
Date: Fri, 6 Mar 2020 10:58:25 +0100
Message-ID: <20200306095825.qmnothvjjemjwh7u@comp-core-i7-2640m-0182e6> (raw)
In-Reply-To: <20200306075934.3104-2-lucas.demarchi@intel.com>

On Thu, Mar 05, 2020 at 11:59:34PM -0800, Lucas De Marchi wrote:
> For all the other indexes what we do is to add a .bin to the original
> filename to denote it's the indexed version of that file. It was
> kernel's decision to name it modules.builtin.modinfo, so respect that.
> 
> Fix: b866b2165ae6 ("Lookup aliases in the modules.builtin.modinfo")
> ---
>  tools/depmod.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/depmod.c b/tools/depmod.c
> index 875e314..fe1c54d 100644
> --- a/tools/depmod.c
> +++ b/tools/depmod.c
> @@ -2402,7 +2402,7 @@ static int output_devname(struct depmod *depmod, FILE *out)
>  	return 0;
>  }
>  
> -static int output_builtin_alias_bin(struct depmod *depmod, FILE *out)
> +static int output_builtin_modinfo_bin(struct depmod *depmod, FILE *out)
>  {
>  	int ret = 0, count = 0;
>  	struct index_node *idx;
> @@ -2482,7 +2482,7 @@ static int depmod_output(struct depmod *depmod, FILE *out)
>  		{ "modules.symbols", output_symbols },
>  		{ "modules.symbols.bin", output_symbols_bin },
>  		{ "modules.builtin.bin", output_builtin_bin },
> -		{ "modules.builtin.alias.bin", output_builtin_alias_bin },
> +		{ "modules.builtin.modinfo.bin", output_builtin_modinfo_bin },

This file does not contain all whole modinfo. Now the function name and
index name will be confusing. But it's up to you.

>  		{ "modules.devname", output_devname },
>  		{ }
>  	};
> -- 
> 2.25.1
> 

-- 
Rgrds, legion


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06  7:59 [PATCH 1/2] depmod: do not output .bin to stdout Lucas De Marchi
2020-03-06  7:59 ` [PATCH 2/2] depmod: just add .bin suffix to builtin.modinfo Lucas De Marchi
2020-03-06  9:58   ` Alexey Gladkov [this message]
2020-03-09 21:46     ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200306095825.qmnothvjjemjwh7u@comp-core-i7-2640m-0182e6 \
    --to=gladkov.alexey@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=yaneti@declera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org
	public-inbox-index linux-modules

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git