From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F13C433E6 for ; Tue, 19 Jan 2021 18:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A602A22CAD for ; Tue, 19 Jan 2021 18:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390688AbhASSck (ORCPT ); Tue, 19 Jan 2021 13:32:40 -0500 Received: from vmicros1.altlinux.org ([194.107.17.57]:39000 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390332AbhASScU (ORCPT ); Tue, 19 Jan 2021 13:32:20 -0500 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 253B172C8B3; Tue, 19 Jan 2021 21:31:31 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 1796C7CC8A4; Tue, 19 Jan 2021 21:31:31 +0300 (MSK) Date: Tue, 19 Jan 2021 21:31:31 +0300 From: "Dmitry V. Levin" To: Lucas De Marchi Cc: linux-modules@vger.kernel.org, Jan Tojnar Subject: Re: [PATCH 2/3] depmod: fix precedence order Message-ID: <20210119183130.GA10896@altlinux.org> References: <20210119145238.12774-1-lucas.demarchi@intel.com> <20210119145238.12774-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119145238.12774-2-lucas.demarchi@intel.com> Precedence: bulk List-ID: On Tue, Jan 19, 2021 at 06:52:37AM -0800, Lucas De Marchi wrote: > Configuration in /etc should have higher prio than /run. Should it? Isn't the common practice nowadays to have /run override /etc? > Given how rarely configuration in /run is used with depmod, this is > likely not to cause any problems, even if it's a change in behavior. > --- > tools/depmod.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/depmod.c b/tools/depmod.c > index 3f31cdf..8e1d9ec 100644 > --- a/tools/depmod.c > +++ b/tools/depmod.c > @@ -51,8 +51,8 @@ static int verbose = DEFAULT_VERBOSE; > static const char CFG_BUILTIN_KEY[] = "built-in"; > static const char CFG_EXTERNAL_KEY[] = "external"; > static const char *default_cfg_paths[] = { > - "/run/depmod.d", > SYSCONFDIR "/depmod.d", > + "/run/depmod.d", > "/lib/depmod.d", > NULL > }; -- ldv