From: Petr Vorel <petr.vorel@gmail.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
linux-modules@vger.kernel.org
Subject: Re: [PATCH 2/2] testsuite: move zstd-compressed module to a separate test
Date: Thu, 28 Jan 2021 21:54:52 +0100 [thread overview]
Message-ID: <20210128205452.GA139886@pevik> (raw)
In-Reply-To: <20210128191000.GI6564@kitsune.suse.cz>
Hi Lucas, Michal,
> Hello,
> I think a simpler approach would be to not compress the module list for
> which the decompressor is not configured in populate-modules.sh Then the
> depmod test can run unchanged, and the modules will only be compressed
> when support for the compression is enabled.
+1
> The issue with this is that populate-modules.sh does not have any input
> for these configure settings - they are in config.h but that's not very
> useble for a shell script.
How about grep for them in '#define KMOD_FEATURES ...' line. Everything is
there:
#define KMOD_FEATURES "-ZSTD +XZ -ZLIB -LIBCRYPTO -EXPERIMENTAL"
Kind regards,
Petr
> Thanks
> Michal
prev parent reply other threads:[~2021-01-28 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 14:47 [PATCH 1/2] testsuite: use skip for modules-order-compressed Lucas De Marchi
2021-01-28 14:47 ` [PATCH 2/2] testsuite: move zstd-compressed module to a separate test Lucas De Marchi
[not found] ` <20210128191000.GI6564@kitsune.suse.cz>
2021-01-28 20:54 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128205452.GA139886@pevik \
--to=petr.vorel@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).