linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
diff for duplicates of <20210130023600.24239-2-lucas.demarchi@intel.com>

diff --git a/a/1.txt b/N1/1.txt
index d50a289..7ffb4eb 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -1,33 +1,41 @@
----
- testsuite/populate-modules.sh | 9 +++++++++
- 1 file changed, 9 insertions(+)
+Hi,
 
-diff --git a/testsuite/populate-modules.sh b/testsuite/populate-modules.sh
-index ae43884..099f026 100755
---- a/testsuite/populate-modules.sh
-+++ b/testsuite/populate-modules.sh
-@@ -72,6 +72,9 @@ map=(
- 
- gzip_array=(
-     "test-depmod/modules-order-compressed/lib/modules/4.4.4/kernel/drivers/block/cciss.ko"
-+    )
-+
-+xz_array=(
-     "test-depmod/modules-order-compressed/lib/modules/4.4.4/kernel/drivers/scsi/scsi_mod.ko"
-     )
- 
-@@ -112,6 +115,12 @@ if feature_enabled ZLIB; then
- 	done
- fi
- 
-+if feature_enabled XZ; then
-+	for m in "${xz_array[@]}"; do
-+	    xz "$ROOTFS/$m"
-+	done
-+fi
-+
- if feature_enabled ZSTD; then
- 	for m in "${zstd_array[@]}"; do
- 	    zstd --rm $ROOTFS/$m
--- 
-2.30.0
\ No newline at end of file
+Reviewed-by: Petr Vorel <pvorel@suse.cz>
+
+Thanks!
+
+BTW I still have issues with testsuite/test-depmod locally, but probably my
+wrong setup (testing also other configure options than this one):
+
+$ CFLAGS='-g -O2' --enable-debug && make -j`nproc` && make check
+
+depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory
+depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory
+TESTSUITE: running depmod_search_order_override, in forked context
+TESTSUITE: SKIPPED: depmod_search_order_override
+TESTSUITE: ------
+TESTSUITE: running depmod_search_order_external_last, in forked context
+TESTSUITE: 'depmod_search_order_external_last' [31183] exited with return code 0
+TESTSUITE: PASSED: depmod_search_order_external_last
+TESTSUITE: ------
+TESTSUITE: running depmod_search_order_external_first, in forked context
+TESTSUITE: SKIPPED: depmod_search_order_external_first
+TESTSUITE: ------
+TESTSUITE: running depmod_detect_loop, in forked context
+TESTSUITE: SKIPPED: depmod_detect_loop
+TESTSUITE: ------
+TESTSUITE: running depmod_search_order_same_prefix, in forked context
+TESTSUITE: 'depmod_search_order_same_prefix' [31182] exited with return code 0
+TESTSUITE: ERR: sizes do not match /src/kmod/testsuite/rootfs/test-depmod/search-order-same-prefix/lib/modules/4.4.4/correct-modules.dep /src/kmod/testsuite/rootfs/test-depmod/search-order-same-prefix/lib/modules/4.4.4/modules.dep
+TESTSUITE: ERR: FAILED: exit ok but outputs do not match: depmod_search_order_same_prefix
+TESTSUITE: ------
+FAIL testsuite/test-depmod (exit status: 1)
+
+Kind regards,
+Petr
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 0a27037..8182a27 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -1,21 +1,18 @@
 [
-  "ref\00020210130023600.24239-1-lucas.demarchi\@intel.com\0"
+  "From\0Petr Vorel <pvorel\@suse.cz>\0"
 ]
 [
-  "From\0Lucas De Marchi <lucas.demarchi\@intel.com>\0"
+  "Subject\0Re: [PATCH 2/2] testsuite: also test xz compression\0"
 ]
 [
-  "Subject\0[PATCH 2/2] testsuite: also test xz compression\0"
+  "Date\0Thu, 4 Feb 2021 11:32:41 +0100\0"
 ]
 [
-  "Date\0Fri, 29 Jan 2021 18:36:00 -0800\0"
+  "To\0Lucas De Marchi <lucas.demarchi\@intel.com>\0"
 ]
 [
-  "To\0linux-modules\@vger.kernel.org\0"
-]
-[
-  "Cc\0Michal Such\303\241nek <msuchanek\@suse.de>",
-  " Petr Vorel <petr.vorel\@gmail.com>\0"
+  "Cc\0linux-modules\@vger.kernel.org",
+  " Michal Such\303\241nek <msuchanek\@suse.de>\0"
 ]
 [
   "\0000:1\0"
@@ -24,39 +21,47 @@
   "b\0"
 ]
 [
-  "---\n",
-  " testsuite/populate-modules.sh | 9 +++++++++\n",
-  " 1 file changed, 9 insertions(+)\n",
+  "Hi,\n",
+  "\n",
+  "Reviewed-by: Petr Vorel <pvorel\@suse.cz>\n",
+  "\n",
+  "Thanks!\n",
+  "\n",
+  "BTW I still have issues with testsuite/test-depmod locally, but probably my\n",
+  "wrong setup (testing also other configure options than this one):\n",
+  "\n",
+  "\$ CFLAGS='-g -O2' --enable-debug && make -j`nproc` && make check\n",
+  "\n",
+  "depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory\n",
+  "depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory\n",
+  "TESTSUITE: running depmod_search_order_override, in forked context\n",
+  "TESTSUITE: SKIPPED: depmod_search_order_override\n",
+  "TESTSUITE: ------\n",
+  "TESTSUITE: running depmod_search_order_external_last, in forked context\n",
+  "TESTSUITE: 'depmod_search_order_external_last' [31183] exited with return code 0\n",
+  "TESTSUITE: PASSED: depmod_search_order_external_last\n",
+  "TESTSUITE: ------\n",
+  "TESTSUITE: running depmod_search_order_external_first, in forked context\n",
+  "TESTSUITE: SKIPPED: depmod_search_order_external_first\n",
+  "TESTSUITE: ------\n",
+  "TESTSUITE: running depmod_detect_loop, in forked context\n",
+  "TESTSUITE: SKIPPED: depmod_detect_loop\n",
+  "TESTSUITE: ------\n",
+  "TESTSUITE: running depmod_search_order_same_prefix, in forked context\n",
+  "TESTSUITE: 'depmod_search_order_same_prefix' [31182] exited with return code 0\n",
+  "TESTSUITE: ERR: sizes do not match /src/kmod/testsuite/rootfs/test-depmod/search-order-same-prefix/lib/modules/4.4.4/correct-modules.dep /src/kmod/testsuite/rootfs/test-depmod/search-order-same-prefix/lib/modules/4.4.4/modules.dep\n",
+  "TESTSUITE: ERR: FAILED: exit ok but outputs do not match: depmod_search_order_same_prefix\n",
+  "TESTSUITE: ------\n",
+  "FAIL testsuite/test-depmod (exit status: 1)\n",
   "\n",
-  "diff --git a/testsuite/populate-modules.sh b/testsuite/populate-modules.sh\n",
-  "index ae43884..099f026 100755\n",
-  "--- a/testsuite/populate-modules.sh\n",
-  "+++ b/testsuite/populate-modules.sh\n",
-  "\@\@ -72,6 +72,9 \@\@ map=(\n",
-  " \n",
-  " gzip_array=(\n",
-  "     \"test-depmod/modules-order-compressed/lib/modules/4.4.4/kernel/drivers/block/cciss.ko\"\n",
-  "+    )\n",
-  "+\n",
-  "+xz_array=(\n",
-  "     \"test-depmod/modules-order-compressed/lib/modules/4.4.4/kernel/drivers/scsi/scsi_mod.ko\"\n",
-  "     )\n",
-  " \n",
-  "\@\@ -112,6 +115,12 \@\@ if feature_enabled ZLIB; then\n",
-  " \tdone\n",
-  " fi\n",
-  " \n",
-  "+if feature_enabled XZ; then\n",
-  "+\tfor m in \"\${xz_array[\@]}\"; do\n",
-  "+\t    xz \"\$ROOTFS/\$m\"\n",
-  "+\tdone\n",
-  "+fi\n",
-  "+\n",
-  " if feature_enabled ZSTD; then\n",
-  " \tfor m in \"\${zstd_array[\@]}\"; do\n",
-  " \t    zstd --rm \$ROOTFS/\$m\n",
-  "-- \n",
-  "2.30.0"
+  "Kind regards,\n",
+  "Petr"
 ]
 
-3e9378afa4aafc6ebf4fd2c045663fc37c61cde334702a5e3bbbd91210e24ffc
+b631ff9101a6ad8b070c04c2c7674bcf25b3cced702fa690b7d606f612135c41

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).