linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: linux-modules@vger.kernel.org
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Subject: [PATCH 2/3] depmod: fix modules.builtin.alias.bin output
Date: Tue, 11 May 2021 11:06:14 -0700	[thread overview]
Message-ID: <20210511180615.400191-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20210511180615.400191-1-lucas.demarchi@intel.com>

Due to wrong documentation on kmod_module_get_info() we ended up
checking for 0 as return. Check for > 0 to decided if we want to write
the index to the file, otherwise we would output a 0-sized index on
success.
---
 tools/depmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/depmod.c b/tools/depmod.c
index 170a1d8..eb810b8 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -2457,7 +2457,7 @@ static int output_builtin_alias_bin(struct depmod *depmod, FILE *out)
 
 out:
 	/* do not bother writing the index if we are going to discard it */
-	if (!ret)
+	if (ret > 0)
 		index_write(idx, out);
 
 	if (builtin)
-- 
2.31.1


  parent reply	other threads:[~2021-05-11 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 18:06 [PATCH 0/3] Fix modules.builtin.alias.bin creation Lucas De Marchi
2021-05-11 18:06 ` [PATCH 1/3] Fix return value doc for kmod_module_get_info() Lucas De Marchi
2021-05-11 18:06 ` Lucas De Marchi [this message]
2021-05-11 18:06 ` [PATCH 3/3] testsuite: update gitignore Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511180615.400191-3-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=peter.kjellerstedt@axis.com \
    --subject='Re: [PATCH 2/3] depmod: fix modules.builtin.alias.bin output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).