From: Steven Rostedt <rostedt@goodmis.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
christophe.leroy@csgroup.eu, cl@linux.com, mbenes@suse.cz,
akpm@linux-foundation.org, jeyu@kernel.org,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
void@manifault.com, atomlin@atomlin.com, allen.lkml@gmail.com,
joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name,
jason.wessel@windriver.com, pmladek@suse.com,
daniel.thompson@linaro.org, hch@infradead.org,
Chuck Lever III <chuck.lever@oracle.com>
Subject: Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file
Date: Sun, 3 Jul 2022 09:23:05 -0400 [thread overview]
Message-ID: <20220703092305.1e5da4c2@rorschach.local.home> (raw)
In-Reply-To: <20220703083324.az24ou7nrngvp73v@ava.usersys.com>
On Sun, 3 Jul 2022 09:33:24 +0100
Aaron Tomlin <atomlin@redhat.com> wrote:
> On Fri 2022-07-01 15:34 -0700, Luis Chamberlain wrote:
> > Poke, did you get to implement this yet?
>
> Hi Luis, Steve,
>
> Firstly, apologies for the delay.
>
> I believe I found the issue:
>
> diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c
> index 1b0780e20aab..84808706af5c 100644
> --- a/kernel/module/kallsyms.c
> +++ b/kernel/module/kallsyms.c
> @@ -197,7 +197,7 @@ void add_kallsyms(struct module *mod, const struct load_info *info)
> mod->kallsyms->typetab[i];
> dst[ndst] = src[i];
> dst[ndst++].st_name = s - mod->core_kallsyms.strtab;
> - s += strscpy(s, &mod->kallsyms->strtab[src[i].st_name],
> + s += strlcpy(s, &mod->kallsyms->strtab[src[i].st_name],
> KSYM_NAME_LEN) + 1;
> }
> }
>
> That being said, I need to examine the precise differences between each
> implementation; albeit, I believe we can revert this particular change. I
> will send a patch for a wider discussion shortly.
>
> - Before
>
> $ grep -a -E '^[0-9a-f]{16} [^a-z].*\[virtio_console\]' /proc/kallsyms
> 0000000000000000 notifier_del_vio [virtio_console]
> 0000000000000000 show_port_name [virtio_console]
> 0000000000000000 port_debugfs_open [virtio_console]
>
> - After the above modification
>
> $ grep -a -E '^[0-9a-f]{16} [^a-z].*\[virtio_console\]' /proc/kallsyms
> $ grep -a -m 3 -E '^[0-9a-f]{16} [a-z].*\[virtio_console\]' /proc/kallsyms
> 0000000000000000 t notifier_del_vio [virtio_console]
> 0000000000000000 t show_port_name [virtio_console]
> 0000000000000000 t port_debugfs_open [virtio_console]
>
>
BTW, *NEVER* modify code that you are moving. Really, *NEVER* do that!
It makes debugging much more difficult, like in this very case.
*ALWAYS* have the moving of code be a separate patch. Keep as most
identical as humanly possible. Even keep white space errors the same!
You can add a clean up patch before or after the move. But never do it
as one patch!
You even stated "no functional change" which was a lie. Converting
strlcpy() to strscpy() *is* a functional change!
-- Steve
next prev parent reply other threads:[~2022-07-03 13:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 10:23 [PATCH v11 00/14] module: core code clean up Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 01/14] module: Move all into module/ Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 02/14] module: Simple refactor in preparation for split Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 03/14] module: Make internal.h and decompress.c more compliant Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 04/14] module: Move livepatch support to a separate file Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 05/14] module: Move latched RB-tree " Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 06/14] module: Move strict rwx " Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 07/14] module: Move extra signature support out of core code Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 08/14] module: Move kmemleak support to a separate file Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 09/14] module: Move kallsyms support into " Aaron Tomlin
2022-06-28 4:05 ` Steven Rostedt
2022-06-28 8:19 ` Aaron Tomlin
2022-07-01 22:34 ` Luis Chamberlain
2022-07-03 8:33 ` Aaron Tomlin
2022-07-03 13:23 ` Steven Rostedt [this message]
2022-07-03 13:57 ` Aaron Tomlin
2022-07-03 14:13 ` Steven Rostedt
2022-07-03 14:24 ` Aaron Tomlin
2022-07-03 17:58 ` Christophe Leroy
2022-07-03 23:18 ` Steven Rostedt
2022-03-10 10:24 ` [PATCH v11 10/14] module: kallsyms: Fix suspicious rcu usage Aaron Tomlin
2022-06-28 3:56 ` Steven Rostedt
2022-06-28 16:21 ` Aaron Tomlin
2022-06-28 16:24 ` Steven Rostedt
2022-03-10 10:24 ` [PATCH v11 11/14] module: Move procfs support into a separate file Aaron Tomlin
2022-03-10 10:26 ` [PATCH v11 12/14] module: Move sysfs " Aaron Tomlin
2022-03-10 10:26 ` [PATCH v11 13/14] module: Move kdb module related code out of main kdb code Aaron Tomlin
2022-03-10 10:30 ` Aaron Tomlin
2022-03-11 16:17 ` Daniel Thompson
2022-03-11 18:00 ` Luis Chamberlain
2022-03-10 10:26 ` [PATCH v11 14/14] module: Move version support into a separate file Aaron Tomlin
2022-03-10 10:32 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220703092305.1e5da4c2@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=chuck.lever@oracle.com \
--cc=cl@linux.com \
--cc=daniel.thompson@linaro.org \
--cc=hch@infradead.org \
--cc=jason.wessel@windriver.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=msuchanek@suse.de \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).