From: kernel test robot <lkp@intel.com>
To: Zhen Lei <thunder.leizhen@huawei.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-modules@vger.kernel.org
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH v3 8/8] kallsyms: Add self-test facility
Date: Tue, 20 Sep 2022 11:14:07 +0800 [thread overview]
Message-ID: <202209201126.fpHaqBEx-lkp@intel.com> (raw)
In-Reply-To: <20220919151533.1734-9-thunder.leizhen@huawei.com>
Hi Zhen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mcgrof/modules-next]
[also build test WARNING on linus/master v6.0-rc6 next-20220919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
config: arm-nhk8815_defconfig (https://download.01.org/0day-ci/archive/20220920/202209201126.fpHaqBEx-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
git checkout 26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/kallsyms.c:196:15: warning: no previous prototype for 'kallsyms_sym_address' [-Wmissing-prototypes]
196 | unsigned long kallsyms_sym_address(int idx)
| ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c:668:12: warning: no previous prototype for 'arch_get_kallsym' [-Wmissing-prototypes]
668 | int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
| ^~~~~~~~~~~~~~~~
vim +/kallsyms_sym_address +196 kernel/kallsyms.c
195
> 196 unsigned long kallsyms_sym_address(int idx)
197 {
198 if (!IS_ENABLED(CONFIG_KALLSYMS_BASE_RELATIVE))
199 return kallsyms_addresses[idx];
200
201 /* values are unsigned offsets if --absolute-percpu is not in effect */
202 if (!IS_ENABLED(CONFIG_KALLSYMS_ABSOLUTE_PERCPU))
203 return kallsyms_relative_base + (u32)kallsyms_offsets[idx];
204
205 /* ...otherwise, positive offsets are absolute values */
206 if (kallsyms_offsets[idx] >= 0)
207 return kallsyms_offsets[idx];
208
209 /* ...and negative offsets are relative to kallsyms_relative_base - 1 */
210 return kallsyms_relative_base - 1 - kallsyms_offsets[idx];
211 }
212
--
0-DAY CI Kernel Test Service
https://01.org/lkp
prev parent reply other threads:[~2022-09-20 3:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:15 [PATCH v3 0/8] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-09-19 15:15 ` [PATCH v3 1/8] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 2/8] scripts/kallsyms: ensure that all possible combinations are compressed Zhen Lei
2022-09-19 15:15 ` [PATCH v3 3/8] scripts/kallsyms: don't compress symbol types Zhen Lei
2022-09-19 15:15 ` [PATCH v3 4/8] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 5/8] kallsyms: Add helper kallsyms_on_each_match_symbol() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 6/8] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-09-19 15:15 ` [PATCH v3 7/8] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 8/8] kallsyms: Add self-test facility Zhen Lei
2022-09-20 3:14 ` kernel test robot
2022-09-20 6:13 ` Leizhen (ThunderTown)
2022-09-20 3:14 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209201126.fpHaqBEx-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).