linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
	Thor Thayer <thor.thayer@linux.intel.com>,
	Lee Jones <lee@kernel.org>
Subject: [PATCH 03/24] kbuild, mfd: altera-sysmgr: remove MODULE_LICENSE in non-modules
Date: Fri, 17 Feb 2023 14:10:38 +0000	[thread overview]
Message-ID: <20230217141059.392471-4-nick.alcock@oracle.com> (raw)
In-Reply-To: <20230217141059.392471-1-nick.alcock@oracle.com>

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Thor Thayer <thor.thayer@linux.intel.com>
Cc: Lee Jones <lee@kernel.org>
---
 drivers/mfd/altera-sysmgr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
index 5d3715a28b28..af205813b281 100644
--- a/drivers/mfd/altera-sysmgr.c
+++ b/drivers/mfd/altera-sysmgr.c
@@ -198,4 +198,3 @@ module_exit(altr_sysmgr_exit);
 
 MODULE_AUTHOR("Thor Thayer <>");
 MODULE_DESCRIPTION("SOCFPGA System Manager driver");
-MODULE_LICENSE("GPL v2");
-- 
2.39.1.268.g9de2f9a303


  parent reply	other threads:[~2023-02-17 14:11 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 14:10 [PATCH 00/24] MODULE_LICENSE removals, second tranche Nick Alcock
2023-02-17 14:10 ` [PATCH 01/24] kbuild, soc: fujitsu: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-17 14:10 ` [PATCH 02/24] kbuild, PCI: " Nick Alcock
2023-02-17 15:02   ` Bjorn Helgaas
2023-02-17 14:10 ` Nick Alcock [this message]
2023-02-17 14:10 ` [PATCH 04/24] kbuild, irqchip/al-fic: " Nick Alcock
2023-02-17 14:10 ` [PATCH 05/24] kbuild, cpufreq: amd-pstate: " Nick Alcock
2023-02-23 19:02   ` Rafael J. Wysocki
2023-02-17 14:10 ` [PATCH 06/24] kbuild, binder: " Nick Alcock
2023-02-17 20:18   ` Carlos Llamas
2023-02-17 14:10 ` [PATCH 07/24] kbuild, bus: arm-integrator-lm: " Nick Alcock
2023-02-17 14:10 ` [PATCH 08/24] kbuild, drivers/perf: " Nick Alcock
2023-02-17 14:10 ` [PATCH 09/24] kbuild, ARM: tegra: " Nick Alcock
2023-04-05 13:09   ` (subset) " Thierry Reding
2023-02-17 14:10 ` [PATCH 10/24] kbuild, pinctrl: actions: " Nick Alcock
2023-02-17 14:10 ` [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: " Nick Alcock
2023-02-19 12:38   ` Sven Peter
2023-02-20  5:00   ` Eric Curtin
2023-02-17 14:10 ` [PATCH 12/24] kbuild, soc: sunxi: sram: " Nick Alcock
2023-02-21 18:24   ` Jernej Škrabec
2023-03-14 20:39   ` Jernej Škrabec
2023-02-17 14:10 ` [PATCH 13/24] kbuild, clk: bm1880: " Nick Alcock
2023-02-17 22:43   ` Stephen Boyd
2023-02-17 14:10 ` [PATCH 14/24] kbuild, firmware: imx: " Nick Alcock
2023-03-14  1:35   ` Shawn Guo
2023-03-20 10:36     ` Nick Alcock
2023-03-20 21:42       ` Luis Chamberlain
2023-02-17 14:10 ` [PATCH 15/24] kbuild, bus: ixp4xx: " Nick Alcock
2023-02-17 14:10 ` [PATCH 16/24] kbuild, irqchip/mvebu-pic: " Nick Alcock
2023-02-17 14:10 ` [PATCH 17/24] kbuild, pinctrl: nuvoton: npcm7xx: " Nick Alcock
2023-02-17 14:10 ` [PATCH 18/24] kbuild, bus: qcom: " Nick Alcock
2023-02-17 14:10 ` [PATCH 19/24] kbuild, bus: " Nick Alcock
2023-02-17 14:10 ` [PATCH 20/24] kbuild, gpio: " Nick Alcock
2023-03-06  9:58   ` Bartosz Golaszewski
2023-02-17 14:10 ` [PATCH 21/24] kbuild, serial: " Nick Alcock
2023-03-09 16:17   ` Greg Kroah-Hartman
2023-02-17 14:10 ` [PATCH 22/24] kbuild, dmaengine: s3c24xx: " Nick Alcock
2023-02-17 14:20   ` Krzysztof Kozlowski
2023-02-17 14:10 ` [PATCH 23/24] kbuild, EDAC, altera: " Nick Alcock
2023-04-01 11:56   ` Borislav Petkov
2023-02-17 14:10 ` [PATCH 24/24] kbuild, power: reset: keystone-reset: " Nick Alcock
2023-03-27 15:01 ` [PATCH 00/24] MODULE_LICENSE removals, second tranche Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217141059.392471-4-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=hasegawa-hitomi@fujitsu.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=thor.thayer@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).