linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: lee@kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 09/18] mfd: 88pm860x: remove MODULE_LICENSE in non-modules
Date: Wed,  8 Mar 2023 19:42:58 +0000	[thread overview]
Message-ID: <20230308194307.374789-9-nick.alcock@oracle.com> (raw)
In-Reply-To: <20230308194307.374789-1-nick.alcock@oracle.com>

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
---
 drivers/mfd/88pm860x-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index 6ba7169cb953a..3c57e537d57fb 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -1276,4 +1276,3 @@ module_exit(pm860x_i2c_exit);
 
 MODULE_DESCRIPTION("PMIC Driver for Marvell 88PM860x");
 MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
-MODULE_LICENSE("GPL");
-- 
2.39.1.268.g9de2f9a303


  parent reply	other threads:[~2023-03-08 19:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 19:42 [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 19:42 ` [PATCH 02/18] mfd: da9052: " Nick Alcock
2023-03-08 19:42 ` [PATCH 03/18] mfd: da9052-i2c: " Nick Alcock
2023-03-08 19:42 ` [PATCH 04/18] mfd: da9052-spi: " Nick Alcock
2023-03-08 19:42 ` [PATCH 05/18] mfd: da9055: " Nick Alcock
2023-03-08 19:42 ` [PATCH 06/18] mfd: da9055-i2c: " Nick Alcock
2023-03-08 19:42 ` [PATCH 07/18] mfd: stmpe-i2c: " Nick Alcock
2023-03-08 19:42 ` [PATCH 08/18] mfd: stmpe-spi: " Nick Alcock
2023-03-08 19:42 ` Nick Alcock [this message]
2023-03-08 19:42 ` [PATCH 10/18] mfd: da9055: do not cite as modular Nick Alcock
2023-03-09 18:29   ` Vincenzo Palazzo
2023-03-08 19:43 ` [PATCH 11/18] mfd: tc3589x: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-08 19:43 ` [PATCH 12/18] mfd: tps6586x: " Nick Alcock
2023-03-08 19:43 ` [PATCH 13/18] mfd: ezx-pcap: " Nick Alcock
2023-03-08 19:43 ` [PATCH 14/18] mfd: lp8788: " Nick Alcock
2023-03-08 19:43 ` [PATCH 15/18] mfd: omap-usb-host: " Nick Alcock
2023-03-08 19:43 ` [PATCH 16/18] mfd: omap-usb-tll: " Nick Alcock
2023-03-08 19:43 ` [PATCH 17/18] mfd: twl4030-audio: " Nick Alcock
2023-03-08 19:43 ` [PATCH 18/18] mfd: twl6040: " Nick Alcock
2023-03-16 15:42 ` [PATCH 01/18] mfd: da903x: " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230308194307.374789-9-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).