linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Pavlu <petr.pavlu@suse.com>
To: Aaron Tomlin <atomlin@redhat.com>, mcgrof@kernel.org
Cc: christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org, atomlin@atomlin.com
Subject: Re: [PATCH modules-next] module: Add debugfs interface to view unloaded tainted modules
Date: Mon, 29 Aug 2022 09:14:32 +0200	[thread overview]
Message-ID: <2bf2b4ee-fd8d-962d-0daa-9c8093ad331e@suse.com> (raw)
In-Reply-To: <20220823193225.2072649-1-atomlin@redhat.com>

On 8/23/22 21:32, Aaron Tomlin wrote:
> [...]
> @@ -59,3 +60,68 @@ void print_unloaded_tainted_modules(void)
>  		}
>  	}
>  }
> +
> +#ifdef CONFIG_DEBUG_FS
> +static void *unloaded_tainted_modules_seq_start(struct seq_file *m, loff_t *pos)
> +{
> +	mutex_lock(&module_mutex);
> +	return seq_list_start_rcu(&unloaded_tainted_modules, *pos);
> +}

unloaded_tainted_modules looks to be a proper RCU list which makes me think
this reader could use just rcu_read_lock() instead of
mutex_lock(&module_mutex)?

Thanks,
Petr

  reply	other threads:[~2022-08-29  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 19:32 [PATCH modules-next] module: Add debugfs interface to view unloaded tainted modules Aaron Tomlin
2022-08-29  7:14 ` Petr Pavlu [this message]
2022-08-31 10:19   ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf2b4ee-fd8d-962d-0daa-9c8093ad331e@suse.com \
    --to=petr.pavlu@suse.com \
    --cc=atomlin@atomlin.com \
    --cc=atomlin@redhat.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).