From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laura Abbott Subject: Re: [PATCH 1/4] build: Properly check for Cython To: Lucas De Marchi , Laura Abbott References: <1442004956-3868-1-git-send-email-labbott@fedoraproject.org> <1442004956-3868-2-git-send-email-labbott@fedoraproject.org> Cc: Lucas De Marchi , linux-modules Message-ID: <55FC4C03.4040101@redhat.com> Date: Fri, 18 Sep 2015 10:38:11 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 09/12/2015 11:27 AM, Lucas De Marchi wrote: > On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott wrote: >> >> Cython is necessary to compile if --enable-python is used. >> Currently, the configuration just sets Cython to ':' if >> it isn't found. ':' is a valid command which results in >> confusing build errors: >> >> CCLD libkmod/libkmod.la >> CCLD libkmod/libkmod-internal.la >> ar: `u' modifier ignored since `D' is the default (see `U') >> CYTHON libkmod/python/kmod/kmod.c >> CC libkmod/python/kmod/libkmod_python_kmod_kmod_la-kmod.lo >> gcc: error: ./libkmod/python/kmod/kmod.c: No such file or directory >> gcc: fatal error: no input files >> >> Explicitly check if cython is available and then error out >> if it isn't found. >> --- > > Since we distribute the generated python files, cython is only needed > on "building from git tree" cases, not for packages. > > > Lucas De Marchi > I don't think I have a clear answer about whether or not you want to take this patch even after Kay's response. If you don't want to add the autoconf check I'll update the README and put a note under hacking to make sure cython is installed if the intention is to ship the generated files. Thanks, Laura