From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650DBC678D5 for ; Tue, 7 Mar 2023 13:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbjCGNLe (ORCPT ); Tue, 7 Mar 2023 08:11:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230471AbjCGNLQ (ORCPT ); Tue, 7 Mar 2023 08:11:16 -0500 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFF2836096 for ; Tue, 7 Mar 2023 05:09:51 -0800 (PST) Received: by mail-yb1-xb2a.google.com with SMTP id v101so11314585ybi.2 for ; Tue, 07 Mar 2023 05:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678194525; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BUyLL3WLDfVQzfFJ1cTgHx1F2T4l0rvv5mYeuKbfNsQ=; b=f0voQHR50eKQn9pWmH4okHQLwspQ+PoKv5Kzdda/RrrkGGfmtex9EAriYrGVMqBdCN uIlvDmU4524gP19vJ/EDVqVtcvd12x8mMg1sDcdjLmjnN1IDLRv/NWyV3jxMWbWkviCt 2JnXueygaWOrmlncuFbWNX2S/wEf+rUAqJBgGl24gAKhvQ2BNsbqXz9w/zPqBna8J7pk ISWoMp95GiuXqKWCHNsIOXoMEi6vYl5TtrVPIZ3bIjGuTwHYt4s0yV/EAKUcm6hTmdvM LnLG4iHZ1GN/wRShBoZDVs5u14NzL2aqRWB8fc8n5mlYwlQU0waZkSrcomJJ7lQ4+iDg u06Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678194525; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BUyLL3WLDfVQzfFJ1cTgHx1F2T4l0rvv5mYeuKbfNsQ=; b=tUTWKg/fpYLGFBQkGJZsXFfx6XeemTDvaylVPjwqIi4Xpz7JGwDJHIEn9uKNbWfeVk zdYwiWJFrk0vBO+YiGFJKBWpjqgWXWaJHBbT/T8euUVvEyIweH8on2upwyZi+7FGEX8s fgLdBiiuBpxGy9MAXh1jT6GRBP9c6YGmx9DEceTKsSAmQYlBFRvJ2vodXilbStv5INyl t9Vc3dUyhssRppDE6x9BRtncs2zGO4mziqCXebAIlQM9oPrkQxEGAcflF/wZ4R/zQlNL PMFsBd7WdPVFLeWE+mNz/NrhwsQv6LGXf/HLrI6gZ1/ZgOwlIs+J1tH6obkv046QSKfw aZWg== X-Gm-Message-State: AO0yUKUoOcbLaaGFMInVSD/YDP6qbIp7xfjz9IDUPsMEpPA78uPsFPTq 9fn/E0puEM2yaQx3Hpgv16FaF/DqXx0ZHyCQXoFRpA== X-Google-Smtp-Source: AK7set8G15rudyekwE1NLJ2jrqHCuvOJo7nIba762aX7OQEgLIczx/xEM0GURgzlhd1O+RzQzpIcv3hNWRNtZxm2mww= X-Received: by 2002:a25:8b8f:0:b0:906:307b:1449 with SMTP id j15-20020a258b8f000000b00906307b1449mr8597450ybl.5.1678194525710; Tue, 07 Mar 2023 05:08:45 -0800 (PST) MIME-Version: 1.0 References: <20230228130215.289081-1-nick.alcock@oracle.com> <20230228130215.289081-3-nick.alcock@oracle.com> In-Reply-To: <20230228130215.289081-3-nick.alcock@oracle.com> From: Linus Walleij Date: Tue, 7 Mar 2023 14:08:34 +0100 Message-ID: Subject: Re: [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Basavaraj Natikar , Shyam Sundar S K , linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Tue, Feb 28, 2023 at 2:02 PM Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Basavaraj Natikar > Cc: Shyam Sundar S K > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org Can I just merge the 3 pinctrl patches to the pinctrl tree or are there any dependencies? Yours, Linus Walleij