linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] module support: during lockdown, log name of unsigned module
@ 2020-02-19  9:02 Martin Haass
  2020-02-26 17:58 ` Jessica Yu
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Haass @ 2020-02-19  9:02 UTC (permalink / raw)
  To: Jessica Yu; +Cc: linux-kernel, linux-security-module, linux-modules

during lockdown loading of unsigned modules is restricted to signed
modules only. The old error message does not show which module misses
the signature, making it very difficult for a user to determine which
module is at fault.
This patch adds a line to the logs which additionally contains the
module name that caused the error message. The old message cannot
be replaced as it is generated by lockdown_is_locked_down
---
 kernel/module.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 33569a01d6e..6dcb28139a0 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2807,7 +2807,8 @@ static int module_sig_check(struct load_info *info,
int flags)
  const unsigned long markerlen = sizeof(MODULE_SIG_STRING) - 1;
  const char *reason;
  const void *mod = info->hdr;
-
+ int is_locked = -EPERM;
+
  /*
  * Require flags == 0, as a module with version information
  * removed is no longer the module that was signed
@@ -2843,7 +2844,12 @@ static int module_sig_check(struct load_info *info,
int flags)
  return -EKEYREJECTED;
  }

- return security_locked_down(LOCKDOWN_MODULE_SIGNATURE);
+ is_locked = security_locked_down(LOCKDOWN_MODULE_SIGNATURE);
+ if (is_locked == -EPERM) {
+ pr_notice("Lockdown: %s: rejected module '%s' cause: %s",
+ current->comm, info->name, reason);
+ }
+ return is_locked;

  /* All other errors are fatal, including nomem, unparseable
  * signatures and signature check failures - even if signatures
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-26 17:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19  9:02 [PATCH] module support: during lockdown, log name of unsigned module Martin Haass
2020-02-26 17:58 ` Jessica Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).