linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Jessica Yu <jeyu@kernel.org>,
	Colin Ian King <colin.king@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Yu Chen <chen.yu@easystack.cn>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-modules@vger.kernel.org
Subject: Re: Modules updates for v5.17-rc1
Date: Mon, 17 Jan 2022 07:38:25 +0200	[thread overview]
Message-ID: <CAHk-=wjCajUWAZBNrQv3zrrjZBH7e7x2UrQ2n18+yk3TpGD9ag@mail.gmail.com> (raw)
In-Reply-To: <YeITMG7bKozB2xVQ@bombadil.infradead.org>

On Sat, Jan 15, 2022 at 2:20 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> Although this change was only merged on January 11th, the patches have
> been being reviewed since early december. There was at least one fix
> already found for it and merged.

Grr..

And that's exactly why it matters not about "being reviewed", but when
they were in linux-next etc.

I've pulled this, but consider this a complaint. Things should not be
"reviewed" before the merge window. They should be ready and merged
and have actually seen some testing.

Review is good. But nothing beats actually being out there and
actually seeing real-life testing (of course, linux-next probably
mostly gets build-testing, but what testing it gets is still better
than not being there).

               Linus

  reply	other threads:[~2022-01-17  5:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-15  0:20 Modules updates for v5.17-rc1 Luis Chamberlain
2022-01-17  5:38 ` Linus Torvalds [this message]
2022-01-18 16:16   ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjCajUWAZBNrQv3zrrjZBH7e7x2UrQ2n18+yk3TpGD9ag@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=chen.yu@easystack.cn \
    --cc=colin.king@intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).