Linux-Modules Archive on lore.kernel.org
 help / Atom feed
* [RESEND RESEND PATCH] depmod: Ignore PowerPC64 ABIv2 .TOC. symbol
@ 2016-06-10  5:24 Michael Ellerman
  2016-06-11  3:27 ` Lucas De Marchi
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2016-06-10  5:24 UTC (permalink / raw)
  To: lucas.de.marchi; +Cc: Anton Blanchard, linux-modules

From: Anton Blanchard <anton@samba.org>

The .TOC. symbol on the PowerPC64 ABIv2 identifies the GOT
pointer, similar to how other architectures use _GLOBAL_OFFSET_TABLE_.

This is not a symbol that needs relocation, and should be ignored
by depmod.

---
 tools/depmod.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/depmod.c b/tools/depmod.c
index 6e9bb4d..a2e07c1 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -2153,6 +2153,8 @@ static void depmod_add_fake_syms(struct depmod *depmod)
 	depmod_symbol_add(depmod, "__this_module", true, 0, NULL);
 	/* On S390, this is faked up too */
 	depmod_symbol_add(depmod, "_GLOBAL_OFFSET_TABLE_", true, 0, NULL);
+	/* On PowerPC64 ABIv2, .TOC. is more or less _GLOBAL_OFFSET_TABLE_ */
+	depmod_symbol_add(depmod, "TOC.", true, 0, NULL);
 }
 
 static int depmod_load_symvers(struct depmod *depmod, const char *filename)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RESEND RESEND PATCH] depmod: Ignore PowerPC64 ABIv2 .TOC. symbol
  2016-06-10  5:24 [RESEND RESEND PATCH] depmod: Ignore PowerPC64 ABIv2 .TOC. symbol Michael Ellerman
@ 2016-06-11  3:27 ` Lucas De Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Lucas De Marchi @ 2016-06-11  3:27 UTC (permalink / raw)
  To: Michael Ellerman; +Cc: Anton Blanchard, linux-modules

On Fri, Jun 10, 2016 at 2:24 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> From: Anton Blanchard <anton@samba.org>
>
> The .TOC. symbol on the PowerPC64 ABIv2 identifies the GOT
> pointer, similar to how other architectures use _GLOBAL_OFFSET_TABLE_.
>
> This is not a symbol that needs relocation, and should be ignored
> by depmod.
>
> ---
>  tools/depmod.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/depmod.c b/tools/depmod.c
> index 6e9bb4d..a2e07c1 100644
> --- a/tools/depmod.c
> +++ b/tools/depmod.c
> @@ -2153,6 +2153,8 @@ static void depmod_add_fake_syms(struct depmod *depmod)
>         depmod_symbol_add(depmod, "__this_module", true, 0, NULL);
>         /* On S390, this is faked up too */
>         depmod_symbol_add(depmod, "_GLOBAL_OFFSET_TABLE_", true, 0, NULL);
> +       /* On PowerPC64 ABIv2, .TOC. is more or less _GLOBAL_OFFSET_TABLE_ */
> +       depmod_symbol_add(depmod, "TOC.", true, 0, NULL);
>  }
>
>  static int depmod_load_symvers(struct depmod *depmod, const char *filename)


Applied, thanks

Lucas De Marchi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10  5:24 [RESEND RESEND PATCH] depmod: Ignore PowerPC64 ABIv2 .TOC. symbol Michael Ellerman
2016-06-11  3:27 ` Lucas De Marchi

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org linux-modules@archiver.kernel.org
	public-inbox-index linux-modules


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/ public-inbox