From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Michal Suchanek <msuchanek@suse.de>
Cc: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>,
linux-modules <linux-modules@vger.kernel.org>,
Ferry van Steen <Ferry.van.Steen@citrus.nl>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] libkmod-signature: pkcs#7: fix crash when signer info is not present.
Date: Mon, 11 Jun 2018 10:12:10 -0700 [thread overview]
Message-ID: <CAKi4VA+=Twgsz_6vEyuGx=pqYBqpZO0fcqWrukqtMc7R-9EtiA@mail.gmail.com> (raw)
In-Reply-To: <20180608171015.2211-1-msuchanek@suse.de>
On Fri, Jun 8, 2018 at 10:10 AM Michal Suchanek <msuchanek@suse.de> wrote:
>
> Reported-by: Kazuya Saito <saito.kazuya@jp.fujitsu.com>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> libkmod/libkmod-signature.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libkmod/libkmod-signature.c b/libkmod/libkmod-signature.c
> index fae074e6dd1d..782e96f69fef 100644
> --- a/libkmod/libkmod-signature.c
> +++ b/libkmod/libkmod-signature.c
> @@ -166,7 +166,7 @@ kmod_module_signature_info_pkcs7(const char *mem,
What's this based on? There's no such function in upstream
Lucas De Marchi
> sig_info->key_id_len = cert->key_id_size;
>
> sig_info->signer = cert->signer;
> - sig_info->signer_len = strlen(cert->signer);
> + sig_info->signer_len = cert->signer ? strlen(cert->signer) : 0;
>
> sig_info->algo = NULL;
> sig_info->hash_algo = cert->hash_algo;
> --
> 2.13.6
>
--
Lucas De Marchi
next prev parent reply other threads:[~2018-06-11 17:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 13:58 [PATCH RFC PKCS7 asn1c 0/2] asn1c version of PKCS#7 parser Yauheni Kaliuta
2018-03-08 13:58 ` [PATCH RFC PKCS7 asn1c 1/2] libkmod-signature: implement pkcs7 parsing with asn1c compiler Yauheni Kaliuta
2018-03-08 18:14 ` [PATCH] libkmod-signature: Fix crash when module signature is not present Michal Suchanek
2018-03-12 20:41 ` Yauheni Kaliuta
2018-03-13 9:57 ` Michal Suchánek
2018-03-13 10:03 ` Yauheni Kaliuta
2018-06-08 17:10 ` [PATCH] libkmod-signature: pkcs#7: fix crash when signer info " Michal Suchanek
2018-06-11 17:12 ` Lucas De Marchi [this message]
2018-06-11 17:42 ` Michal Suchánek
2018-03-08 13:58 ` [PATCH RFC PKCS7 asn1c 2/2] libkmod, pkcs7: commit asn1c autogenerated files Yauheni Kaliuta
2018-03-12 15:45 ` Michal Suchánek
2018-03-12 15:42 ` [PATCH RFC PKCS7 asn1c 0/2] asn1c version of PKCS#7 parser Michal Suchánek
2018-03-12 20:40 ` Yauheni Kaliuta
2018-03-13 9:54 ` Michal Suchánek
2019-01-22 20:01 ` Yauheni Kaliuta
2019-01-22 20:03 ` Michal Suchánek
2019-01-22 20:34 ` Yauheni Kaliuta
2019-01-22 20:43 ` Lucas De Marchi
2019-01-22 22:07 ` Michal Suchánek
2019-01-25 13:40 ` Yauheni Kaliuta
2019-01-23 8:41 ` Yauheni Kaliuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKi4VA+=Twgsz_6vEyuGx=pqYBqpZO0fcqWrukqtMc7R-9EtiA@mail.gmail.com' \
--to=lucas.de.marchi@gmail.com \
--cc=Ferry.van.Steen@citrus.nl \
--cc=dhowells@redhat.com \
--cc=linux-modules@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=yauheni.kaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).