Linux-Modules Archive on lore.kernel.org
 help / color / Atom feed
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	linux-modules <linux-modules@vger.kernel.org>,
	Yanko Kaneti <yaneti@declera.com>
Subject: Re: [PATCH 2/2] depmod: just add .bin suffix to builtin.modinfo
Date: Mon, 9 Mar 2020 14:46:25 -0700
Message-ID: <CAKi4VA+QDwsoyqPKA4UJTCJ-K600WEAb8tg9FuwWvnQNe7cPUA@mail.gmail.com> (raw)
In-Reply-To: <20200306095825.qmnothvjjemjwh7u@comp-core-i7-2640m-0182e6>

On Fri, Mar 6, 2020 at 1:58 AM Alexey Gladkov <gladkov.alexey@gmail.com> wrote:
>
> On Thu, Mar 05, 2020 at 11:59:34PM -0800, Lucas De Marchi wrote:
> > For all the other indexes what we do is to add a .bin to the original
> > filename to denote it's the indexed version of that file. It was
> > kernel's decision to name it modules.builtin.modinfo, so respect that.
> >
> > Fix: b866b2165ae6 ("Lookup aliases in the modules.builtin.modinfo")
> > ---
> >  tools/depmod.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/depmod.c b/tools/depmod.c
> > index 875e314..fe1c54d 100644
> > --- a/tools/depmod.c
> > +++ b/tools/depmod.c
> > @@ -2402,7 +2402,7 @@ static int output_devname(struct depmod *depmod, FILE *out)
> >       return 0;
> >  }
> >
> > -static int output_builtin_alias_bin(struct depmod *depmod, FILE *out)
> > +static int output_builtin_modinfo_bin(struct depmod *depmod, FILE *out)
> >  {
> >       int ret = 0, count = 0;
> >       struct index_node *idx;
> > @@ -2482,7 +2482,7 @@ static int depmod_output(struct depmod *depmod, FILE *out)
> >               { "modules.symbols", output_symbols },
> >               { "modules.symbols.bin", output_symbols_bin },
> >               { "modules.builtin.bin", output_builtin_bin },
> > -             { "modules.builtin.alias.bin", output_builtin_alias_bin },
> > +             { "modules.builtin.modinfo.bin", output_builtin_modinfo_bin },
>
> This file does not contain all whole modinfo. Now the function name and
> index name will be confusing. But it's up to you.

Indeed. I'd also have to fix the libkmod counterpart, otherwise it
would look for the wrong file.
This index contains only the alias -> module, like our modules.alias file.

I think it would be better to leave it with this name.  It would
probably be good to output
modules.builtin.alias though to make it similar to the
modules.alias/modules.alias.bin case.
Another option is to just add those aliases to modules.alias and
lookup modules.builtin to decide
if that's builtin, but I  think I prefer to keep them separate.

thanks
Lucas De Marchi


>
> >               { "modules.devname", output_devname },
> >               { }
> >       };
> > --
> > 2.25.1
> >
>
> --
> Rgrds, legion
>


-- 
Lucas De Marchi

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06  7:59 [PATCH 1/2] depmod: do not output .bin to stdout Lucas De Marchi
2020-03-06  7:59 ` [PATCH 2/2] depmod: just add .bin suffix to builtin.modinfo Lucas De Marchi
2020-03-06  9:58   ` Alexey Gladkov
2020-03-09 21:46     ` Lucas De Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKi4VA+QDwsoyqPKA4UJTCJ-K600WEAb8tg9FuwWvnQNe7cPUA@mail.gmail.com \
    --to=lucas.de.marchi@gmail.com \
    --cc=gladkov.alexey@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=yaneti@declera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org
	public-inbox-index linux-modules

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git