Linux-Modules Archive on lore.kernel.org
 help / color / Atom feed
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: linux-modules <linux-modules@vger.kernel.org>,
	Lucas De Marchi <lucas.de.marchi@gmail.com>
Subject: Re: [PATCH v2 0/4] Add modules.builtin.modinfo support
Date: Fri, 20 Dec 2019 10:45:09 -0800
Message-ID: <CAKi4VA+QrgGNWSKwZx5NFQWtFdF_M=6_V4_LrV7dEhqvncePdw@mail.gmail.com> (raw)
In-Reply-To: <20191204152723.nnmumapusw5zeacl@comp-core-i7-2640m-0182e6>

On Wed, Dec 4, 2019 at 7:27 AM Alexey Gladkov <gladkov.alexey@gmail.com> wrote:
>
> On Fri, Nov 08, 2019 at 06:25:19PM +0100, Alexey Gladkov wrote:
> > The kernel since version v5.2-rc1 exports information about built-in
> > modules in the modules.builtin.modinfo. Now, kmod can show complete information
> > about the built-in modules as well as about external modules. Also kmod can
> > understand aliases of built-in modules.
> >
> > Before:
> >
> > $ modinfo block-major-9-1
> > modinfo: ERROR: Module block-major-9-1 not found.
> >
> > After:
> >
> > $ modinfo block-major-9-1
> > name:           md_mod
> > filename:       (builtin)
> > alias:          block-major-9-*
> > alias:          md
> > description:    MD RAID framework
> > license:        GPL
> > parm:           start_dirty_degraded:int
> > parm:           create_on_open:bool
> >
> > v2:
> >
> > * Don't use kmod_file() to parse modules.builtin.modinfo. Instead, parser reads
> > the file into the buffer by chunks, which reduces the amount of memory.
> >
> > Alexey Gladkov (4):
> >   libkmod: Add parser for modules.builtin.modinfo
> >   libkmod: Add function to get list of built-in modules
> >   Lookup aliases in the modules.builtin.modinfo
> >   modinfo: Show information about built-in modules
>
> ping.

sorry for the delay, it took me some time to go through it and review.

Applied,
thanks

Lucas De Marchi

>
> >  Makefile.am                |   1 +
> >  libkmod/libkmod-builtin.c  | 329 +++++++++++++++++++++++++++++++++++++
> >  libkmod/libkmod-internal.h |  10 ++
> >  libkmod/libkmod-module.c   |  73 +++++++-
> >  libkmod/libkmod.c          |  25 +++
> >  libkmod/libkmod.h          |   1 +
> >  tools/depmod.c             |  63 +++++++
> >  tools/modinfo.c            |  39 +++--
> >  8 files changed, 514 insertions(+), 27 deletions(-)
> >  create mode 100644 libkmod/libkmod-builtin.c
> >
> > --
> > 2.21.0
> >
>
> --
> Rgrds, legion
>


-- 
Lucas De Marchi

      reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 17:25 Alexey Gladkov
2019-11-08 17:25 ` [PATCH v2 1/4] libkmod: Add parser for modules.builtin.modinfo Alexey Gladkov
2019-11-08 17:25 ` [PATCH v2 2/4] libkmod: Add function to get list of built-in modules Alexey Gladkov
2019-11-08 17:25 ` [PATCH v2 3/4] Lookup aliases in the modules.builtin.modinfo Alexey Gladkov
2019-11-08 17:25 ` [PATCH v2 4/4] modinfo: Show information about built-in modules Alexey Gladkov
2019-11-18 23:17 ` [PATCH v2 0/4] Add modules.builtin.modinfo support Alexey Gladkov
2019-12-04 15:27 ` Alexey Gladkov
2019-12-20 18:45   ` Lucas De Marchi [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKi4VA+QrgGNWSKwZx5NFQWtFdF_M=6_V4_LrV7dEhqvncePdw@mail.gmail.com' \
    --to=lucas.de.marchi@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org
	public-inbox-index linux-modules

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git