Re: [PATCH v2 0/4] Add modules.builtin.modinfo support

[Lucas De Marchi <lucas.de.marchi@gmail.com>]

On Wed, Dec 4, 2019 at 7:27 AM Alexey Gladkov <gladkov.alexey@gmail.com> wrote:
>
> On Fri, Nov 08, 2019 at 06:25:19PM +0100, Alexey Gladkov wrote:
> > The kernel since version v5.2-rc1 exports information about built-in
> > modules in the modules.builtin.modinfo. Now, kmod can show complete information
> > about the built-in modules as well as about external modules. Also kmod can
> > understand aliases of built-in modules.
> >
> > Before:
> >
> > $ modinfo block-major-9-1
> > modinfo: ERROR: Module block-major-9-1 not found.
> >
> > After:
> >
> > $ modinfo block-major-9-1
> > name:           md_mod
> > filename:       (builtin)
> > alias:          block-major-9-*
> > alias:          md
> > description:    MD RAID framework
> > license:        GPL
> > parm:           start_dirty_degraded:int
> > parm:           create_on_open:bool
> >
> > v2:
> >
> > * Don't use kmod_file() to parse modules.builtin.modinfo. Instead, parser reads
> > the file into the buffer by chunks, which reduces the amount of memory.
> >
> > Alexey Gladkov (4):
> >   libkmod: Add parser for modules.builtin.modinfo
> >   libkmod: Add function to get list of built-in modules
> >   Lookup aliases in the modules.builtin.modinfo
> >   modinfo: Show information about built-in modules
>
> ping.

sorry for the delay, it took me some time to go through it and review.

Applied,
thanks

Lucas De Marchi

>
> >  Makefile.am                |   1 +
> >  libkmod/libkmod-builtin.c  | 329 +++++++++++++++++++++++++++++++++++++
> >  libkmod/libkmod-internal.h |  10 ++
> >  libkmod/libkmod-module.c   |  73 +++++++-
> >  libkmod/libkmod.c          |  25 +++
> >  libkmod/libkmod.h          |   1 +
> >  tools/depmod.c             |  63 +++++++
> >  tools/modinfo.c            |  39 +++--
> >  8 files changed, 514 insertions(+), 27 deletions(-)
> >  create mode 100644 libkmod/libkmod-builtin.c
> >
> > --
> > 2.21.0
> >
>
> --
> Rgrds, legion
>


-- 
Lucas De Marchi