linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Michal Suchanek <msuchanek@suse.de>
Cc: linux-modules <linux-modules@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.de>, Petr Vorel <pvorel@suse.cz>
Subject: Re: [PATCH] libkmod: Set builtin to no when module is created from path.
Date: Wed, 18 Aug 2021 14:23:56 -0700	[thread overview]
Message-ID: <CAKi4VAJ6suukX93gjruTG3H66NeA6PxQ40hR2_+hL5m11LQ_ZQ@mail.gmail.com> (raw)
In-Reply-To: <20210818205159.6066-1-msuchanek@suse.de>

On Wed, Aug 18, 2021 at 1:53 PM Michal Suchanek <msuchanek@suse.de> wrote:
>
> Something like this?

yep. Just a matter of style but I think I like the *mod = m as the
last thing. Let me send it with that additional change.

thanks
Lucas De Marchi

>
> Thanks
>
> Michal
>
> --------------------------------------------------------------------
>
> A recent bug report showed that modinfo doesn't give the signature
> information for certain modules, and it turned out to happen only on
> the modules that are built-in on the running kernel; then modinfo
> skips the signature check, as if the target module file never exists.
> The behavior is, however, inconsistent when modinfo is performed for
> external modules (no matter which kernel version is) and the module
> file path is explicitly given by a command-line argument, which
> guarantees the presence of the module file itself.
>
> Fixes: e7e2cb61fa9f ("modinfo: Show information about built-in modules")
> Link: https://lore.kernel.org/linux-modules/CAKi4VAJVvY3=JdSZm-GD1hJqyCPYaYz-jBJ_REeY5BakVb6_ww@mail.gmail.com/
> BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1189537
> Suggested-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  libkmod/libkmod-module.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
> index 9e878a5345a1..53b220d492e8 100644
> --- a/libkmod/libkmod-module.c
> +++ b/libkmod/libkmod-module.c
> @@ -432,18 +432,18 @@ KMOD_EXPORT int kmod_module_new_from_path(struct kmod_ctx *ctx,
>                 }
>
>                 *mod = kmod_module_ref(m);
> -               return 0;
> -       }
> +       } else {
> +               err = kmod_module_new(ctx, name, name, namelen, NULL, 0, &m);
> +               if (err < 0) {
> +                       free(abspath);
> +                       return err;
> +               }
>
> -       err = kmod_module_new(ctx, name, name, namelen, NULL, 0, &m);
> -       if (err < 0) {
> -               free(abspath);
> -               return err;
> +               m->path = abspath;
> +               *mod = m;
>         }
>
> -       m->path = abspath;
> -       *mod = m;
> -
> +       (*mod)->builtin = KMOD_MODULE_BUILTIN_NO;
>         return 0;
>  }
>
> --
> 2.31.1
>

  reply	other threads:[~2021-08-18 21:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 11:22 [PATCH] modinfo: don't parse built-in for explicitly given module files Takashi Iwai
2021-08-18 11:41 ` Michal Suchánek
2021-08-18 12:05 ` Petr Vorel
2021-08-18 19:13 ` Lucas De Marchi
2021-08-18 20:52   ` [PATCH] libkmod: Set builtin to no when module is created from path Michal Suchanek
2021-08-18 21:23     ` Lucas De Marchi [this message]
2021-08-18 21:24     ` [PATCH v2] " Lucas De Marchi
2021-08-18 21:24       ` [PATCH] " Lucas De Marchi
2021-08-19 15:28       ` [PATCH v2] " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKi4VAJ6suukX93gjruTG3H66NeA6PxQ40hR2_+hL5m11LQ_ZQ@mail.gmail.com \
    --to=lucas.de.marchi@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=msuchanek@suse.de \
    --cc=pvorel@suse.cz \
    --cc=tiwai@suse.de \
    --subject='Re: [PATCH] libkmod: Set builtin to no when module is created from path.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).