linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Laura Abbott <labbott@fedoraproject.org>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	linux-modules <linux-modules@vger.kernel.org>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 0/4] depmod and modprobe error message fixups
Date: Sat, 12 Sep 2015 16:05:46 -0300	[thread overview]
Message-ID: <CAKi4VAJ78KbPGtsjopGDKPbxNogSG1=pNJcg7N2HuLzpz54=7Q@mail.gmail.com> (raw)
In-Reply-To: <1442004956-3868-1-git-send-email-labbott@fedoraproject.org>

Hi Laura,

CC'ing Lennart and Kay

On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott <labbott@fedoraproject.org> wrote:
>
> While doing some experimental work with kernel packaging,
> I found a few places where a lack of error messages made
> it difficult to figure out what was going on. This cleans
> up the error messages to be a bit more useful.
>
> Laura Abbott (4):
>   build: Properly check for Cython
>   modprobe: Add appropriate error message when path is missing
>   depmod: Fix message printing before log_setup_kmod_log
>   depmod: Add error message for bad version

Thanks very much for the patches. I commented on each of them
individually.  Could you send a v2 with the comments addressed?

For the cython patch, I'm not sure. I don't want the cython dependency
to be a one off since there are other things we ship prebuilt in
packages like the man pages. Maybe just stop shipping prebuilt stuff
in the distributed file like systemd did would be ok. Lennart, Kay,
did you had any problems with distributions due to this?


Lucas De Marchi

  parent reply	other threads:[~2015-09-12 19:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 20:55 [PATCH 0/4] depmod and modprobe error message fixups Laura Abbott
2015-09-11 20:55 ` [PATCH 1/4] build: Properly check for Cython Laura Abbott
2015-09-12 18:27   ` Lucas De Marchi
2015-09-18 17:38     ` Laura Abbott
2015-09-24  1:11       ` Lucas De Marchi
2015-09-11 20:55 ` [PATCH 2/4] modprobe: Add appropriate error message when path is missing Laura Abbott
2015-09-12 18:45   ` Lucas De Marchi
2015-09-11 20:55 ` [PATCH 3/4] depmod: Fix message printing before log_setup_kmod_log Laura Abbott
2015-09-12 18:55   ` Lucas De Marchi
2015-09-18 18:26     ` Laura Abbott
2015-09-24  1:16       ` Lucas De Marchi
2015-09-11 20:55 ` [PATCH 4/4] depmod: Add error message for bad version Laura Abbott
2015-09-12 19:00   ` Lucas De Marchi
2015-09-18 18:30     ` Laura Abbott
2015-09-24  1:17       ` Lucas De Marchi
2015-09-12 19:05 ` Lucas De Marchi [this message]
2015-09-16 23:35   ` [PATCH 0/4] depmod and modprobe error message fixups Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKi4VAJ78KbPGtsjopGDKPbxNogSG1=pNJcg7N2HuLzpz54=7Q@mail.gmail.com' \
    --to=lucas.de.marchi@gmail.com \
    --cc=kay.sievers@vrfy.org \
    --cc=labbott@fedoraproject.org \
    --cc=lennart@poettering.net \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).