From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: linux-modules <linux-modules@vger.kernel.org>,
Petr Vorel <petr.vorel@gmail.com>
Subject: Re: depmod test fails when zstd not available
Date: Thu, 28 Jan 2021 05:18:56 -0800 [thread overview]
Message-ID: <CAKi4VAK6PB1UxwcaPwmL0b0dByq8QcZYuWj5SZVaGjtRuu7BmA@mail.gmail.com> (raw)
In-Reply-To: <20210128130026.GH6564@kitsune.suse.cz>
On Thu, Jan 28, 2021 at 5:02 AM Michal Suchánek <msuchanek@suse.de> wrote:
>
> Hello,
>
> kmod version 28 adds support for zstd. The support is optional but when
> not enabled the depmod test which unconditionally tests zstd fails.
>
> As kmod supports more and more compression methods I think it is not
> reasonable to expect everyone has all copression libraries available.
>
> Do you think it is reasonable to fix the tests to only use teh
> compresion methods enabled by configure?
We specifically added support for skipping tests when the build
options would imply that the test
would fail. It should not be failing, we probably screwed something up.
Lucas De Marchi
>
> Thanks
>
> Michal
next prev parent reply other threads:[~2021-01-28 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 13:00 depmod test fails when zstd not available Michal Suchánek
2021-01-28 13:18 ` Lucas De Marchi [this message]
2021-01-28 16:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKi4VAK6PB1UxwcaPwmL0b0dByq8QcZYuWj5SZVaGjtRuu7BmA@mail.gmail.com \
--to=lucas.de.marchi@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).