Linux-Modules Archive on lore.kernel.org
 help / color / Atom feed
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: linux-modules <linux-modules@vger.kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] Makefile.am: filter -Wl,--no-undefined
Date: Mon, 18 Nov 2019 14:18:07 -0800
Message-ID: <CAKi4VAKB1myn8AuMaV3SjBrthNiTxc8TkE18w95BPdRuzQBn2g@mail.gmail.com> (raw)
In-Reply-To: <20191118215617.395319-1-fontaine.fabrice@gmail.com>

On Mon, Nov 18, 2019 at 1:59 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Commit 1d14ef82f4a3be741bcdf6b1c6d51ce9dce43567 does not completely fix

CC'ing Thomas.

Lucas De Marchi

> the build with python 3.8 as we still get link failure due to
> '-z undefs' being ignored by some versions of ld.
>
> Indeed, -z undefs was added by commit
> 97a232d7335f3bd0231fd9cd39455bde1d563922 in upstream binutils, and this
> commit was first present in binutils 2.30.
> So any toolchain using binutils version older than that won't have
> -z undefs and will build fail on:
>
> /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mips-linux-gnu/5.3.0/../../../../mips-linux-gnu/bin/ld: warning: -z undefs ignored.
>
> /home/naourr/work/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/aarch64_be-linux-gnu/7.3.1/../../../../aarch64_be-linux-gnu/bin/ld: warning: -z undefs ignored.
>
> So filter -Wl,--no-undefined to fix the issue
>
> Fixes:
>  - http://autobuild.buildroot.org/results/e9645d9969481b09f507f6e0d0b35faaa283eb60
>  - http://autobuild.buildroot.org/results/06a6d865b6b7d8ebd793bde214f4a4c40e0962e1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  Makefile.am | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 8e9c90d..47505c1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -173,7 +173,10 @@ CPYTHON_MODULE_CFLAGS = \
>         $(AM_CFLAGS) -DCPYTHON_COMPILING_IN_PYPY=0 \
>         $(PYTHON_NOWARN) $(PYTHON_CFLAGS) \
>         -fvisibility=default
> -CPYTHON_MODULE_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version -shared -Wl,-z,undefs
> +# Filter -Wl,--no-undefined to fix build with python 3.8
> +comma = ,
> +CPYTHON_MODULE_LDFLAGS = $(subst -Wl$(comma)--no-undefined,,$(AM_LDFLAGS))
> +CPYTHON_MODULE_LDFLAGS += -module -avoid-version -shared
>
>  if BUILD_PYTHON
>  pkgpyexec_LTLIBRARIES = \
> --
> 2.24.0
>


-- 
Lucas De Marchi

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 21:56 Fabrice Fontaine
2019-11-18 22:18 ` Lucas De Marchi [this message]
2019-11-18 22:45   ` Thomas Petazzoni

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKi4VAKB1myn8AuMaV3SjBrthNiTxc8TkE18w95BPdRuzQBn2g@mail.gmail.com \
    --to=lucas.de.marchi@gmail.com \
    --cc=fontaine.fabrice@gmail.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org
	public-inbox-index linux-modules

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git