From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Tobias Stoeckmann <tobias@stoeckmann.org>
Cc: linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] Verify memory sizes on 32 bit systems.
Date: Fri, 3 Aug 2018 14:33:51 -0700 [thread overview]
Message-ID: <CAKi4VAKK5MSODC-VbFWG2d0p-eUXqrPbpNiomJb6+BEhfWjBVQ@mail.gmail.com> (raw)
In-Reply-To: <20180803211007.GA97622@pepper.home.stoeckmann.org>
On Fri, Aug 3, 2018 at 2:10 PM Tobias Stoeckmann <tobias@stoeckmann.org> wrote:
>
> On Fri, Aug 03, 2018 at 02:07:34PM -0700, Lucas De Marchi wrote:
> > > + if ((uintmax_t)st.st_size > (uintmax_t)SIZE_MAX)
> >
> > why casting?
>
> Without casting, a warning could be triggered on 64 bit systems,
> because on these systems a signed 64 bit int (off_t) is compared
> with an unsigned 64 bit int (size_t) which could never be larger.
>
> Casting it to uintmax_t, which is at least 64 bits in size,
> silences this error.
so you are casting the *sign* away, ok. But casting only st.st_size
should suffice.
Lucas De Marchi
>
> No technical reason beyond that.
>
>
> Tobias
--
Lucas De Marchi
next prev parent reply other threads:[~2018-08-03 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 19:01 [PATCH] Verify memory sizes on 32 bit systems Tobias Stoeckmann
2018-08-03 21:07 ` Lucas De Marchi
2018-08-03 21:10 ` Tobias Stoeckmann
2018-08-03 21:33 ` Lucas De Marchi [this message]
2018-08-03 21:51 ` Tobias Stoeckmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKi4VAKK5MSODC-VbFWG2d0p-eUXqrPbpNiomJb6+BEhfWjBVQ@mail.gmail.com \
--to=lucas.de.marchi@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=tobias@stoeckmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).