From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Cc: linux-modules <linux-modules@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Jessica Yu <jeyu@redhat.com>
Subject: Re: [PATCH] testsuite: fix test_array_sort pointers inderection
Date: Tue, 8 Nov 2016 22:24:08 -0200 [thread overview]
Message-ID: <CAKi4VAKtjHtK0HfRJz6T6S5HWz8Td3dXtR7++JzFfCYA_+iJig@mail.gmail.com> (raw)
In-Reply-To: <1478638646-5933-1-git-send-email-yauheni.kaliuta@redhat.com>
On Tue, Nov 8, 2016 at 6:57 PM, Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
> The array elements in the tests are strings, what means "char *"
> in =D0=A1. The comparation funtion takes pointers to the elements, so
> the arguments become "char **". It means, that strcmp() cannot be
> used directrly.
>
> The patch creates a wrapper on strcmp() which perfoms
> dereferencing of the "char **" to supply the actual strings to
> strcmp(), and uses the wrapper as a comparation function for the
> qsort() call.
>
> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
> ---
Applied, thanks.
Lucas De Marchi
prev parent reply other threads:[~2016-11-09 0:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 20:57 [PATCH] testsuite: fix test_array_sort pointers inderection Yauheni Kaliuta
2016-11-09 0:24 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKi4VAKtjHtK0HfRJz6T6S5HWz8Td3dXtR7++JzFfCYA_+iJig@mail.gmail.com \
--to=lucas.de.marchi@gmail.com \
--cc=jeyu@redhat.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=yauheni.kaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).